From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH, RFC 0/5] Improve device info handling v2
Date: Wed, 9 Sep 2009 21:05:25 +0300 [thread overview]
Message-ID: <f43fc5580909091105k538a17c8v63a13fc6f4159b08@mail.gmail.com> (raw)
Hello,
Current monitor assumes certain functions are always available.
Because of the shortcomings of the API, devices have to keep some kind
of global state available with static variables, which is ugly.
Add info command registration to the API and make some devices use it.
User visible monitor commands change: 'info' is replaced by 'dev_info'
and also the parameter name may change, for example 'pic' becomes
'i8259.state'.
I'm not too happy about this, maybe 'info' should also handle
registered devices.
v2:
Use a structure to describe the function, thanks to Gerd Hoffmann for the idea.
Update to QDict.
Blue Swirl (5):
monitor: add device info infrastructure
x86/Sparc32: use device info for pic and irq
PCI: use device info
x86: use device info for hpet
PPC: use device info for CPU statistics
cpu-all.h | 3 --
hw/an5206.c | 9 ------
hw/arm_pic.c | 10 -------
hw/cris_pic_cpu.c | 5 ---
hw/i8259.c | 51 +++++++++++++++++++++-------------
hw/microblaze_pic_cpu.c | 5 ---
hw/pc.c | 12 ++++++++
hw/pc.h | 2 -
hw/pci.c | 51 +++++++++++++++++++---------------
hw/pci.h | 2 -
hw/shix.c | 10 -------
hw/slavio_intctl.c | 26 +++++++++++-------
hw/sun4c_intctl.c | 16 +++++++++-
hw/sun4m.c | 15 +---------
hw/sun4m.h | 8 -----
hw/sun4u.c | 8 -----
monitor.c | 70 ++++++++++++++++++++++++++---------------------
monitor.h | 10 +++++++
qemu-monitor.hx | 17 +++++-------
target-ppc/cpu.h | 2 +
target-ppc/helper.c | 4 +++
target-ppc/translate.c | 45 ++++++++++++++++++++----------
vl.c | 18 ++++++------
23 files changed, 204 insertions(+), 195 deletions(-)
reply other threads:[~2009-09-09 18:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580909091105k538a17c8v63a13fc6f4159b08@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).