From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmLat-00074W-VT for qemu-devel@nongnu.org; Sat, 12 Sep 2009 01:56:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmLap-0006zk-AY for qemu-devel@nongnu.org; Sat, 12 Sep 2009 01:56:18 -0400 Received: from [199.232.76.173] (port=53559 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmLan-0006zX-Vk for qemu-devel@nongnu.org; Sat, 12 Sep 2009 01:56:14 -0400 Received: from mail-ew0-f221.google.com ([209.85.219.221]:39417) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmLan-0005XP-5B for qemu-devel@nongnu.org; Sat, 12 Sep 2009 01:56:13 -0400 Received: by ewy21 with SMTP id 21so1547570ewy.8 for ; Fri, 11 Sep 2009 22:56:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20090910171903.GA16143@1und1.de> References: <4AA7A6EC.10907@codemonkey.ws> <4AA90592.7080100@codemonkey.ws> <4AA90F7F.2030709@redhat.com> <4AA92122.3050103@codemonkey.ws> <4AA924AE.8060807@redhat.com> <4AA927D8.7000900@codemonkey.ws> <4AA92ADF.80003@redhat.com> <4AA92B7A.7010304@codemonkey.ws> <4AA92D5F.9070205@redhat.com> <20090910171903.GA16143@1und1.de> From: Blue Swirl Date: Sat, 12 Sep 2009 08:55:51 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained? Content-Type: multipart/mixed; boundary=001636c59756f4284e04735b1646 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , Anthony Liguori , Amit Shah , Mark McLoughlin , Bernhard Kauer , qemu-devel@nongnu.org --001636c59756f4284e04735b1646 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 10, 2009 at 8:19 PM, Reimar D=C3=B6ffinger wrote: > On Thu, Sep 10, 2009 at 07:46:23PM +0300, Avi Kivity wrote: >> On 09/10/2009 07:38 PM, Anthony Liguori wrote: >> > Well the question is, should I/you edit this, or reject the patch >> > requesting a better changelog? >> > >> > Certainly, the later is what akpm often does. >> >> I'm happy to reject patches for whitespace but I will edit changelogs. >> My rationale is that many people don't care about that and I can't make >> them care; further the log is mostly for my own benefit - I spend quite >> a lot of time reading it when hunting regressions or preparing >> patchqueues for upstream. > > I'd also add that anyone used to projects using SVN will probably be > used to writing only a general explanation of the patch while the real > commit message is left to whoever commits it. Maybe they ideally should > be identical, but I expect that quite a few people _won't_ expect their > email to appear 1:1 in the repository as log message (I usually feel > quite embarrassed when my hastily written email by which I only wanted > to get first comments ends up in a project's permanent history). > I am sure it misses a lot of stuff and there might even be objections to > some parts, but I wrote this draft of a "PATCHES" (or "CONTRIBUTING" or > whatever) file that might help newcomers (and even some long-term > developers might not know all the unwritten rules ;-). > Suggested text: > > This is a (very) rough guide on how to submit patches to qemu, what is ex= pected > of you and what to expect from the process. > Patches should go to the qemu-devel@nongnu.org list, subscription is poss= ible > via http://lists.nongnu.org/mailman/listinfo/qemu-devel > The subject for any emails containing patches should start with [PATCH] s= o it is > obvious that there is a patch included. > Whenever you send a new patch or a new version of a patch, you should sta= rt a new > thread - i.e. do _not_ reply to any email but write a new one. > Patches are preferred inline (i.e. not as attachments - but be careful yo= ur mailer > does not mangle them e.g. by adding line breaks). > Emails generated via "git format-patch" are even better. > Also be aware that emails are often used as-is as log messages, so try to= write > your emails in a way that is suitable for this, in particular they should= in an > understandable and not too verbose way describe what change was made and > why. > Also do not forget to add the appropriate Signed-off-by lines. > Do not expect an immediate reply to your patches, reacting to patches sim= ply > takes some time. If there is no reaction and you checked that the patch w= as > not already applied (there currently is no notification about this) try s= ending > the patch once again, it might just have got lost or forgotten at some > point. We had a discussion about this earlier this year: http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01184.html Since that we have switched to git, so a lot of it could be simplified. Instead of the lengthy formatting specification, we could just require that the patch should apply with "git-am" to git HEAD without any editing, merging or even apply.whitespace=3Dfix. --001636c59756f4284e04735b1646 Content-Type: plain/text; name="submitting_patches.diff" Content-Disposition: attachment; filename="submitting_patches.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fzhxwmvm0 SW5kZXg6IHFlbXUvU1VCTUlUVElOR19QQVRDSEVTCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIC9kZXYvbnVsbAkx OTcwLTAxLTAxIDAwOjAwOjAwLjAwMDAwMDAwMCArMDAwMAorKysgcWVtdS9TVUJNSVRUSU5HX1BB VENIRVMJMjAwOS0wNC0xOSAxNjo0OToyMC4wMDAwMDAwMDAgKzAwMDAKQEAgLTAsMCArMSwxMTkg QEAKK1doZXJlYXMgdGhlIFFFTVUgZGV2ZWxvcGVycyBoaWdobHkgYXBwcmVjaWF0ZSBhbnkgcGF0 Y2hlcywgaXQgd291bGQgYmUKK21vc3QgaGVscGZ1bCBmb3IgYWxsIHBhcnRpZXMgaWYgdGhlIGZv bGxvd2luZyBydWxlcyB3ZXJlIGZvbGxvd2VkIGluCitvcmRlciB0byBzaW1wbGlmeSBtZWNoYW5p Y2FsIGV4dHJhY3Rpb24gYW5kIGFwcGx5aW5nIG9mIHRoZQorcGF0Y2hlcy4gUGF0Y2ggbWFuYWdl bWVudCB1dGlsaXRpZXMgKGdpdCBzZW5kLWVtYWlsLCBxdWlsdCwgYW5kCitzaW1pbGFyKSBjYW4g YXNzaXN0IGluIHByb2R1Y2luZyBjb21wYXRpYmxlIHBhdGNoZXMgYW5kIHBhdGNoIHNldHMKK3dp dGggY29ycmVjdCBmb3JtYXR0aW5nIGV0Yy4sIHNvIHRoZWlyIHVzZSBpcyByZWNvbW1lbmRlZC4K KworMS4gRm9ybWF0IG9mIGUtbWFpbCBzdWJqZWN0CisKK1NQMS4xOiBUaGUgZS1tYWlsIHN1Ympl Y3QgbXVzdCBjb250YWluICJQQVRDSCIgaW4gYnJhY2tldHMsIGZvbGxvd2VkCitieSB3aGl0ZSBz cGFjZSBhbmQgYSBzaG9ydCBzdW1tYXJ5IG9mIHRoZSBjaGFuZ2UKKworU1AxLjI6IFRoZSBicmFj a2V0ZWQgdGV4dCBtYXkgYWxzbyBpbmNsdWRlIG90aGVyIGNvbW1vbmx5IHVzZWQgdGFncworc2Vw YXJhdGVkIHdpdGggYSBjb21tYSBhbmQgd2hpdGUgc3BhY2UsIGluY2x1ZGluZyAiUkZDIiAoUmVx dWVzdCBmb3IKK0NvbW1lbnRzLCBmb3IgcGF0Y2hlcyBzdWJtaXR0ZWQgZm9yIGRpc2N1c3Npb24g YW5kIHJldmlldyBwdXJwb3Nlcworb25seSkgYW5kICJSRlQiIChSZXF1ZXN0IGZvciBUZXN0aW5n LCBmb3IgcGF0Y2hlcyB3aGljaCBhcmUgc3VzcGVjdGVkCit0byBpbnRyb2R1Y2UgcHJvYmxlbXMg aW4gdXNlIGNhc2VzIHdoaWNoIGhhdmUgbm90IGJlZW4gdGVzdGVkIGJ5IHRoZQorc3VibWl0dGVy KQorCitTUDEuMzogVGhlIHN1bW1hcnkgbXVzdCBiZSBzdWl0YWJsZSBmb3IgY2hhbmdlbG9nIGFz IGlzIChzdGFydCB3aXRoIGEKK2NhcGl0YWwgbGV0dGVyIGV0Yy4pIGFmdGVyIGRlbGV0aW5nIHRo ZSBicmFja2V0ZWQgdGV4dCwgd2hpdGUgc3BhY2UKK2FmdGVyIGl0IGFuZCBhbnkgdGV4dCBwcmVj ZWRpbmcgaXQKKworMi4gRm9ybWF0IG9mIGUtbWFpbCBib2R5CisKK1NQMi4xOiBUaGUgZS1tYWls IGJvZHkgbXVzdCBjb250YWluIGEgZGVzY3JpcHRpb24gb2YgdGhlIGNoYW5nZSwKK3N1aXRhYmxl IGZvciBjaGFuZ2Vsb2cgd2l0aG91dCBhbnkgZWRpdGluZworCitTUDIuMjogVGhlIHBhdGNoIGRl c2NyaXB0aW9uIG11c3QgYmUgc2VsZnN0YW5kaW5nIChub3QgZGVwZW5kIG9uIG90aGVyCitwYXRj aGVzLCBvdGhlciBtZXNzYWdlcyBvciBiYWNrZ3JvdW5kIGRpc2N1c3Npb24pCisKK1NQMi4zOiBU aGUgZGVzY3JpcHRpb24gbXVzdCBiZSBmb2xsb3dlZCBieSBvbmUgYmxhbmsgbGluZSBhbmQgYQor IlNpZ25lZC1vZmYtYnk6IiBsaW5lCisKK1NQMi40OiBPcHRpb25hbGx5LCB0aGUgIlNpZ25lZC1v ZmYtYnk6IiBsaW5lIG1heSBiZSBmb2xsb3dlZCB3aXRoIGEKK2xpbmUgd2l0aCBvbmx5ICItLS0i IGFuZCBvbiB0aGUgZm9sbG93aW5nIGxpbmVzLCBvdGhlciBjb21tZW50cyBub3QKK2ludGVuZGVk IGZvciBjaGFuZ2Vsb2cgKGZvciBleGFtcGxlIGRpZmZzdGF0LCBsb2NhdGlvbiBvZiBhIGdpdCB0 cmVlLAord2hldGhlciB0aGUgcGF0Y2ggaXMgYWxzbyBkaXJlY3RlZCB0b3dhcmRzIHN0YWJsZSB0 cmVlLCB3aXR0eQorc2lnbmF0dXJlIGV0Yy4pCisKK1NQMi41OiBFeGNlcHRpb246IEZvciBleHRy ZW1lbHkgc2hvcnQgYW5kIHRyaXZpYWwgcGF0Y2hlcyAob25lLWxpbmUKK2ZpeGVzIGV0Yy4pLCB0 aGUgZGVzY3JpcHRpb24gYW5kICJTaWduZWQtb2ZmLWJ5OiIgbGluZXMgbWF5IGJlCitvbWl0dGVk LCBpbiB3aGljaCBjYXNlIHRoZSBzdWJqZWN0IG11c3QgYmUgYXBwZW5kZWQgd2l0aCB0aGUKK3N1 Ym1pdHRlcidzIG5hbWUgaW4gcGFyZW50aGVzaXMKKworU1AyLjY6IEV4Y2VwdGlvbjogVGhlIHJ1 bGVzIGluIHRoaXMgc2VjdGlvbiBhcmUgbm90IGFwcGxpY2FibGUgZm9yCitwYXRjaGVzIHRhZ2dl ZCB3aXRoICJSRkMiIG9yICJSRlQiCisKKzMuIEF0dGFjaGluZyBwYXRjaGVzIHRvIGUtbWFpbAor CitTUDMuMTogRWFjaCBtZXNzYWdlIG1heSBjb250YWluIG9ubHkgb25lIHBhdGNoCisKK1NQMy4y OiBJZiBwb3NzaWJsZSwgcGxlYXNlIHNlbmQgdGhlIHBhdGNoIGlubGluZWQgKHRvIG1ha2UgY29t bWVudGluZworZWFzaWVyKSBhbmQgYWxzbyBhdHRhY2hlZCAodG8gbWFrZSBpdCBlYXNpZXIgdG8g YXBwbHkpCisKK1NQMy4yOiBJZiB0aGUgcGF0Y2ggaXMgYXR0YWNoZWQgKGFuZCBub3QgaW5saW5l ZCkgaXQgc2hvdWxkIGJlIG1hcmtlZAorYXMgdGV4dC9wbGFpbiBjb250ZW50IHR5cGUKKworU1Az LjM6IFBsZWFzZSBlbnN1cmUgaW4gYWR2YW5jZSB0aGF0IHlvdXIgZS1tYWlsIHRvb2wgZG9lcyBu b3QgbWFuZ2xlCit3aGl0ZSBzcGFjZSBvciBicmVhayBsb25nIGxpbmVzCisKKzQuIEFib3V0IHBh dGNoZXMKKworU1A0LjE6IEl0IG11c3QgYmUgcG9zc2libGUgdG8gYXBwbHkgdGhlIHBhdGNoIHdp dGggcXVpbHQgKGVxdWl2YWxlbnQKK3RvIHBhdGNoIC1wMSkgYW5kICJnaXQgYW0iIHdpdGhvdXQg YW55IGVkaXRpbmcgb3IgZXh0cmEgZmxhZ3MKKworU1A0LjI6IFRoZSBwYXRjaCBtdXN0IGJlIGlu IHVuaWZpZWQgZGlmZiBmb3JtYXQKKworU1A0LjM6IFRoZSBwYXRjaCBtdXN0IGJlIGJhc2VkIGlu IHRoZSBRRU1VIHJvb3QgZGlyZWN0b3J5IChub3QgZm9yCitleGFtcGxlIEtWTSwgWGVuIG9yIGxv d2VyIGxldmVsIHN1YmRpcmVjdG9yeSkKKworU1A0LjQ6IFRoZSBwYXRjaGVzIHRhcmdldGVkIGZv ciBkZXZlbG9wbWVudCBicmFuY2ggbXVzdCBiZSBiYXNlZCBvbgordGhlIGN1cnJlbnQgZGV2ZWxv cG1lbnQgcmVwb3NpdG9yeQorCitTUDQuNTogVGhlIHBhdGNoZXMgdGFyZ2V0ZWQgZm9yIHN0YWJs ZSBicmFuY2ggbXVzdCBiZSBiYXNlZCBvbiB0aGUKK2N1cnJlbnQgc3RhYmxlIHJlcG9zaXRvcnkK KworNS4gQ2hhbmdlcyBtYWRlIGJ5IHRoZSBwYXRjaAorCitTUDUuMTogRG8gbm90IGNvbWJpbmUg Zm9ybWF0dGluZyBjaGFuZ2VzIHdpdGggZnVuY3Rpb25hbCBjaGFuZ2VzCisKK1NQNS4yOiBEbyBu b3QgY29tYmluZSBzZXZlcmFsIGluZGVwZW5kZW50IGZ1bmN0aW9uYWwgY2hhbmdlcyB0byBvbmUK K3BhdGNoIHVubGVzcyByZXF1aXJlZCBieSB0aGUgbG9naWMgb2YgdGhlIGNoYW5nZXMKKworU1A1 LjM6IFRoZSBjaGFuZ2VzIG1heSBub3QgaW50cm9kdWNlIG5ldyB2aW9sYXRpb25zIG9mIENPRElO R19TVFlMRQorCitTUDUuNDogSWYgdGhlIGNoYW5nZXMgaW52b2x2ZSBuZXcgb3IgY2hhbmdlZCB1 c2VyIGludGVyZmFjZSwKK2RvY3VtZW50YXRpb24gYW5kIGhlbHAgbWVzc2FnZXMgbXVzdCBiZSBj aGFuZ2VkIGFzIHdlbGwKKworU1A1LjU6IElmIHRoZSBjaGFuZ2VzIGFkZCBuZXcgZmlsZXMsIG1h a2Ugc3VyZSB0aGF0IHRoZSBwYXRjaCBpbmNsdWRlcwordGhlbSAoZm9yIGV4YW1wbGUsIHVzZSBk aWZmIGZsYWcgLU4pCisKK1NQNS42IFBsZWFzZSBjaGVjayB0aGF0IHRoZSBjaGFuZ2VzIGRvIG5v dCBpbnRyb2R1Y2UgbmV3IHdhcm5pbmdzIHRvCitiZSBlbWl0dGVkIHdoZW4gY29tcGlsaW5nIHRo ZSBzb3VyY2VzLCBwcmVmZXJhYmx5IG5vdCBldmVuIHdoZW4KK2NvbXBpbGluZyB3aXRoIFNwYXJz ZSBjaGVja2VyCisKKzYuIFNlcmllcyBvZiBwYXRjaGVzCisKK1NQNi4xIFBhdGNoIHNlcmllcyBz aG91bGQgYmUgbnVtYmVyZWQgd2l0aCB0aGUgbnVtYmVyIGluY2x1ZGVkIGluc2lkZQordGhlIGJy YWNrZXRzIGluIHRoZSBzdWJqZWN0IChmb3IgZXhhbXBsZSAiW1BBVENIIDA5LzE3XSIpCisKK1NQ Ni4yOiBUaGUgcGF0Y2ggc2VyaWVzIHNob3VsZCBpbmNsdWRlIGEgY292ZXIgbGV0dGVyIGRlc2Ny aWJpbmcgdGhlCitwYXRjaHNldCBpbiBnZW5lcmFsIChhcyBvcHBvc2VkIHRvIGluZGl2aWR1YWwg cGF0Y2ggZGVzY3JpcHRpb25zKQorCitTUDYuMzogTm8gY2hhbmdlcyBpbiBhIHNpbmdsZSBwYXRj aCBpbiB0aGUgcGF0Y2ggc2VyaWVzIG1heSBicmVhayB0aGUKK2FiaWxpdHkgdG8gYmlzZWN0ICht YWtlIHN1cmUgdGhhdCB3aGVuIGFwcGx5aW5nIHRoZSBwYXRjaGVzCitzZXF1ZW50aWFsbHkgc3Rl cCBieSBzdGVwLCB3b3JraW5nIGV4ZWN1dGFibGVzIGNhbiBiZSBwcm9kdWNlZCBhdCBlYWNoCitz dGVwIGFuZCBub3Qgb25seSBhdCB0aGUgZmluYWwgc3RlcCkKKworCis3LiBMZWdhbCBhc3BlY3Rz CisKK1NQNy4xOiBBbnkgbmV3IGZpbGVzIG9yIG1lcmdlcyBmcm9tIG90aGVyIHNvdXJjZXMgbXVz dCBiZSBsaWNlbmNlZAord2l0aCBsaWNlbmNlcyBjb21wYXRpYmxlIHdpdGggUUVNVSBsaWNlbmNp bmcgKGZvciBleGFtcGxlLCBHUEx2MyBvcgorQ0RETCBhcmUgbm90IGNvbXBhdGlibGUpCisKK1NQ Ny4yOiBUaGUgIlNpZ25lZC1vZmYtYnk6IiBsaW5lIGlzIGEgZm9ybSBvZiBsZWdhbCBkZWNsYXJh dGlvbiB3aGljaAordGhlIHN1Ym1pdHRlciBtdXN0IGJlIGF3YXJlIG9mIChwbGVhc2Ugc2VlIExp bnV4CitEb2N1bWVudGF0aW9uL1N1Ym1pdHRpbmdQYXRjaGVzKQo= --001636c59756f4284e04735b1646--