From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqVK0-0000fK-94 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:08:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqVJu-0000f4-PF for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:08:02 -0400 Received: from [199.232.76.173] (port=33231 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqVJu-0000f1-Jr for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:07:58 -0400 Received: from mail-fx0-f214.google.com ([209.85.220.214]:33834) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqVJu-0001h3-4V for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:07:58 -0400 Received: by fxm10 with SMTP id 10so778949fxm.8 for ; Wed, 23 Sep 2009 10:07:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20090923125818.GA13875@redhat.com> References: <20090923125818.GA13875@redhat.com> From: Blue Swirl Date: Wed, 23 Sep 2009 20:07:37 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: comments on: get page size in device init List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Wed, Sep 23, 2009 at 3:58 PM, Michael S. Tsirkin wrote: >> =C2=A0 =C2=A0 Compile msix only once >> >> =C2=A0 =C2=A0 Get page size in device init. >> >> =C2=A0 =C2=A0 Signed-off-by: Blue Swirl > > What was the motivation for the page size change? "Compile msix only once" > It seems the only user passes TARGET_PAGE_SIZE anyway, > using a constant seems clearer and probably generates > less code. No? Yes, but then the code would depend on TARGET_PAGE_SIZE, making it impossible to compile the code only once. Moreover, devices in general (with the exception of maybe virtio and Xen devices and horrible abominations like vmmouse/vmport) should have no knowledge about the CPU. TARGET_PAGE_SIZE is a parameter of the CPU, no device should need to use it. Therefore this commit is actually a cleanup. > Did I miss this patch on qemu-devel? =C2=A0Generally, it's nice to have > patches posted to list to give people a chance to comment, before they > are pushed to the public tree. =C2=A0Right? No, you did not miss anything. I was not nice, sorry about that. > Finally, the 2 changes seem unrelated: why was it a good idea to bundle > them in one commit? Which 2 changes are you referring to? I think all changes are necessary.