From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqVSk-0002zC-40
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:17:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqVSe-0002xq-Tn
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:17:05 -0400
Received: from [199.232.76.173] (port=47253 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqVSe-0002xg-Pm
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:17:00 -0400
Received: from mail-bw0-f211.google.com ([209.85.218.211]:34516)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MqVSd-0003H9-Of
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 13:17:00 -0400
Received: by bwz7 with SMTP id 7so787085bwz.34
	for <qemu-devel@nongnu.org>; Wed, 23 Sep 2009 10:16:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <87iqf9iqx6.fsf@pike.pond.sub.org>
References: <cover.1253661009.git.quintela@redhat.com>
	<83add4094da4dd3ddd50d849623f658e93e482c0.1253661009.git.quintela@redhat.com>
	<761ea48b0909230148l46b757dcwcc9d1c0d5aec9a8@mail.gmail.com>
	<87iqf9iqx6.fsf@pike.pond.sub.org>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Wed, 23 Sep 2009 20:16:38 +0300
Message-ID: <f43fc5580909231016j258146afn310cb27b3e538879@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration
	-Wold-style-definition to QEMU_CFLAGS
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On Wed, Sep 23, 2009 at 7:09 PM, Markus Armbruster <armbru@redhat.com> wrot=
e:
> Laurent Desnogues <laurent.desnogues@gmail.com> writes:
>
>> On Wed, Sep 23, 2009 at 1:19 AM, Juan Quintela <quintela@redhat.com> wro=
te:
>>> ANSI c89 has been with us for a while.
>>>
>>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>>> ---
>>> =C2=A0configure | =C2=A0 =C2=A01 +
>>> =C2=A01 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 62dccd2..81b9ba8 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1648,6 +1648,7 @@ if test "$debug" =3D "no" ; then
>>> =C2=A0fi
>>> =C2=A0QEMU_CFLAGS=3D"-Wall -Wundef -Wendif-labels -Wwrite-strings -Wmis=
sing-prototypes $QEMU_CFLAGS"
>>> =C2=A0QEMU_CFLAGS=3D"-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS=
"
>>> +QEMU_CFLAGS=3D"-Wold-style-declaration -Wold-style-definition $QEMU_CF=
LAGS"
>>
>> Some older versions of gcc don't handle -Wold-style-declaration.
>> For instance gcc 4.1.2.
>
> Pretty old, do we want to support it? =C2=A0If yes, make configure detect
> whether the warning works?

Yes, OpenBSD uses 3.3.5 (propolice).

There are already similar checks for linker flags in configure, new
checks for warnings available would allow a different set of flags for
the latest and greatest GCC and the good old ones.