From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqY0f-0004sV-4m
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:00:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqY0Z-0004l7-Sp
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:00:15 -0400
Received: from [199.232.76.173] (port=52095 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqY0Z-0004kx-Ea
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:00:11 -0400
Received: from mail-fx0-f214.google.com ([209.85.220.214]:57832)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MqY0Y-0000gZ-V9
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 16:00:11 -0400
Received: by fxm10 with SMTP id 10so913414fxm.8
	for <qemu-devel@nongnu.org>; Wed, 23 Sep 2009 13:00:10 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090923191340.GB18947@redhat.com>
References: <20090923125818.GA13875@redhat.com>
	<f43fc5580909231007q7fbad3a0ydb07e8b8e30f5603@mail.gmail.com>
	<4ABA62D0.2060205@codemonkey.ws> <20090923184041.GA18947@redhat.com>
	<f43fc5580909231203l2b80116bi120efaa2752ca867@mail.gmail.com>
	<20090923191340.GB18947@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Wed, 23 Sep 2009 22:59:50 +0300
Message-ID: <f43fc5580909231259m110f340g50cfbad52effa198@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: comments on: get page size in device init
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Sep 23, 2009 at 10:13 PM, Michael S. Tsirkin <mst@redhat.com> wrote=
:
> On Wed, Sep 23, 2009 at 10:03:26PM +0300, Blue Swirl wrote:
>> On Wed, Sep 23, 2009 at 9:40 PM, Michael S. Tsirkin <mst@redhat.com> wro=
te:
>> > On Wed, Sep 23, 2009 at 01:02:56PM -0500, Anthony Liguori wrote:
>> >> Blue Swirl wrote:
>> >>> On Wed, Sep 23, 2009 at 3:58 PM, Michael S. Tsirkin <mst@redhat.com>=
 wrote:
>> >>>
>> >>>>> =C2=A0 =C2=A0 Compile msix only once
>> >>>>>
>> >>>>> =C2=A0 =C2=A0 Get page size in device init.
>> >>>>>
>> >>>>> =C2=A0 =C2=A0 Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>> >>>>>
>> >>>> What was the motivation for the page size change?
>> >>>>
>> >>>
>> >>> "Compile msix only once"
>> >>>
>> >>>
>> >>>> It seems the only user passes TARGET_PAGE_SIZE anyway,
>> >>>> using a constant seems clearer and probably generates
>> >>>> less code. No?
>> >>>>
>> >>>
>> >>> Yes, but then the code would depend on TARGET_PAGE_SIZE, making it
>> >>> impossible to compile the code only once.
>> >>>
>> >>
>> >> We could probably get away with doing
>> >>
>> >> #define TARGET_PAGE_SIZE target_get_page_size()
>> >>
>> >> And take care of a big chunk of this without passing page size
>> >> parameters around.
>> >
>> >
>> > Sounds good.
>>
>> That would work and target_get_page_size() together with
>> get_ram_size() would also handle the virtio case nicely, except for
>> the if (!kvm_enabled() || kvm_has_sync_mmu()) part.
>
> Where's get_ram_size needed?

In virtio-balloon.