From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MshEb-0004QX-Hi
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:15:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MshEX-0004PJ-1H
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:15:33 -0400
Received: from [199.232.76.173] (port=55127 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MshEW-0004PG-TU
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:15:28 -0400
Received: from mail-fx0-f214.google.com ([209.85.220.214]:44420)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MshEW-000204-F7
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:15:28 -0400
Received: by fxm10 with SMTP id 10so1174798fxm.8
	for <qemu-devel@nongnu.org>; Tue, 29 Sep 2009 11:15:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090929161115.GA13885@redhat.com>
References: <20090923200635.GA21246@redhat.com>
	<f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
	<20090924191121.GB29419@redhat.com>
	<f43fc5580909241313s64f14688he6cdb23e2bc2edfb@mail.gmail.com>
	<20090929161115.GA13885@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Tue, 29 Sep 2009 21:15:04 +0300
Message-ID: <f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target
	library, use it in msix)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Sep 29, 2009 at 7:11 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Sep 24, 2009 at 11:13:38PM +0300, Blue Swirl wrote:
>> >> As this is not a clean revert anyway, please don't revert the part ch=
anging
>> >> if (x)
>> >> =C2=A0y;
>> >> else
>> >> =C2=A0z;
>> >>
>> >> to
>> >>
>> >> if (x) {
>> >> =C2=A0y;
>> >> } else {
>> >> =C2=A0z;
>> >> }
>> >
>> > Did I mention I hate this style? But okay :).
>>
>> I'm not a great fan of this either, but this is the CODING_STYLE.
>
> Maybe we can all vote to change this?

Actually, I tried to tweak 'indent' to match QEMU style without much succes=
s.

We could also select a new style, like Linux kernel one. I'm also not
a great fan of that either. But at least 'indent' could be used very
easily and I think there would be other benefits, like reuse of Git
hooks, patch checking scripts and Emacs configs. With full 'indent'
support all sources could be massaged mechanically to make the switch
less painful.

Then there are K&R and GNU styles, but I like them even less.