From: Blue Swirl <blauwirbel@gmail.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [RfC PATCH 1/3] net: macaddr tweaks.
Date: Wed, 30 Sep 2009 20:19:29 +0300 [thread overview]
Message-ID: <f43fc5580909301019p232dc4edifc5a4a9d799c73d3@mail.gmail.com> (raw)
In-Reply-To: <4AC34790.3080008@gnu.org>
On Wed, Sep 30, 2009 at 2:57 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
>
>> +void qemu_macaddr_default_if_unset(macaddr_t macaddr)
>> +{
>> + macaddr_t zero = { 0,0,0,0,0,0 };
>
> Very minor since this is not at all a hot path, but please make it just
>
> static macaddr_t zero;
>
> since otherwise it would be initialized on the stack at run time.
Even better, static const.
next prev parent reply other threads:[~2009-09-30 17:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 19:43 [Qemu-devel] [RfC PATCH 0/3] qdev-ify network cards Gerd Hoffmann
2009-09-25 19:43 ` [Qemu-devel] [RfC PATCH 1/3] net: macaddr tweaks Gerd Hoffmann
2009-09-28 22:42 ` Markus Armbruster
2009-09-29 9:24 ` Gerd Hoffmann
2009-09-30 11:57 ` [Qemu-devel] " Paolo Bonzini
2009-09-30 17:19 ` Blue Swirl [this message]
2009-09-25 19:43 ` [Qemu-devel] [RfC PATCH 2/3] qdev: mac addr property fixups Gerd Hoffmann
2009-09-25 19:43 ` [Qemu-devel] [RfC PATCH 3/3] ne2k_isa: qdev-ify Gerd Hoffmann
2009-09-28 22:50 ` [Qemu-devel] [RfC PATCH 0/3] qdev-ify network cards Markus Armbruster
2009-09-30 7:20 ` Mark McLoughlin
2009-09-30 9:07 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580909301019p232dc4edifc5a4a9d799c73d3@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=bonzini@gnu.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).