From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mt2qM-00069H-Jw
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:19:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mt2qG-0005ys-KD
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:19:56 -0400
Received: from [199.232.76.173] (port=50363 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mt2qG-0005y7-7Y
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:19:52 -0400
Received: from mail-fx0-f214.google.com ([209.85.220.214]:49037)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Mt2qE-0008Ia-E1
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:19:52 -0400
Received: by fxm10 with SMTP id 10so2005500fxm.8
	for <qemu-devel@nongnu.org>; Wed, 30 Sep 2009 10:19:49 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4AC34790.3080008@gnu.org>
References: <1253907783-1231-1-git-send-email-kraxel@redhat.com>
	<1253907783-1231-2-git-send-email-kraxel@redhat.com>
	<4AC34790.3080008@gnu.org>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Wed, 30 Sep 2009 20:19:29 +0300
Message-ID: <f43fc5580909301019p232dc4edifc5a4a9d799c73d3@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [RfC PATCH 1/3] net: macaddr tweaks.
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Wed, Sep 30, 2009 at 2:57 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
>
>> +void qemu_macaddr_default_if_unset(macaddr_t macaddr)
>> +{
>> + =C2=A0 =C2=A0macaddr_t zero =3D { 0,0,0,0,0,0 };
>
> Very minor since this is not at all a hot path, but please make it just
>
> =C2=A0static macaddr_t zero;
>
> since otherwise it would be initialized on the stack at run time.

Even better, static const.