From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtkRx-0004zi-HF for qemu-devel@nongnu.org; Fri, 02 Oct 2009 11:53:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtkRt-0004zW-SV for qemu-devel@nongnu.org; Fri, 02 Oct 2009 11:53:41 -0400 Received: from [199.232.76.173] (port=43693 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtkRt-0004zT-Ov for qemu-devel@nongnu.org; Fri, 02 Oct 2009 11:53:37 -0400 Received: from mx20.gnu.org ([199.232.41.8]:10127) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MtkRt-0006dG-4g for qemu-devel@nongnu.org; Fri, 02 Oct 2009 11:53:37 -0400 Received: from mail-fx0-f214.google.com ([209.85.220.214]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtkRr-0000uL-Fl for qemu-devel@nongnu.org; Fri, 02 Oct 2009 11:53:35 -0400 Received: by fxm10 with SMTP id 10so1254942fxm.8 for ; Fri, 02 Oct 2009 08:53:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4AC527D6.2050609@codemonkey.ws> References: <4AC51C70.2030006@codemonkey.ws> <4AC527D6.2050609@codemonkey.ws> From: Blue Swirl Date: Fri, 2 Oct 2009 18:53:13 +0300 Message-ID: Subject: Re: [Qemu-devel] Re: Commit 99a0949 (using the mailing list) Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paul Brook , "qemu-devel@nongnu.org" On Fri, Oct 2, 2009 at 1:06 AM, Anthony Liguori wro= te: > Anthony Liguori wrote: >> >> I've reverted 99a0949. =C2=A0It's not necessarily a bad change to make b= ut >> something that's so invasive as that absolutely requires some discussion >> before hand. =C2=A0Avoiding "bike-shedding" is not a valid argument for = avoiding >> the list. >> >> For instance, I find the naming to be truly awful and would have liked >> some discussion on a more reasonable naming convention. >> >> I have a very large set of patches in my queue (over 200) that I'm testi= ng >> and trying to commit. =C2=A0A lot of other people do. =C2=A0If we're goi= ng to make a >> change like this, it's very important to coordinate with people so that = they >> can flush their queues and avoid massive merge head-ache. > > After talking to malc, I have to take a fair bit of the blame here. =C2= =A0I made > a comment in another thread that I thought that this sort of change was a > good idea. =C2=A0While I do think it's a good idea, I could have been mor= e clear > that it was a change that needed some more planning and discussion. I think it would be logical to rename the structs with '_t' to CamelCase and drop the '_t', like the other structs are named. I don't know about scalars. It would be logical to use CamelCase as well, but TargetPhysAddr or RAMAddr look like struct names. target_phys_addr and ram_addr, maybe. This also looked very suspicious: -spinlock_t tb_lock =3D SPIN_LOCK_UNLOCKED; +a_spinlock tb_lock =3D SPIN_LOCK_UNLOCKED;