From: Blue Swirl <blauwirbel@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] rom loader: make vga+rom loading target specific
Date: Tue, 13 Oct 2009 17:58:22 +0300 [thread overview]
Message-ID: <f43fc5580910130758w47a2b296yd54e3552478c4823@mail.gmail.com> (raw)
In-Reply-To: <1255431978-4992-3-git-send-email-kraxel@redhat.com>
On Tue, Oct 13, 2009 at 2:06 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> This patch adds a loader-target.c file for target-specific
> rom loading functions. The rom_add_vga() and rom_add_option()
> macros are transformed into functions and sticked in there. They
> load the bios on TARGET_I386 and no nothing on other targets.
IIRC the VGA cards on non-x86 machines contain ROMs too, some (PPC?
Alpha?) machine had a simple x86 emulator just to run the ROM code.
Then you could enable the VGA ROM loading unconditionally. So maybe
the patch isn't necessary?
Otherwise you could add two files without macros, then the files can
be compiled just once.
next prev parent reply other threads:[~2009-10-13 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 11:06 [Qemu-devel] [PATCH 0/4] more rom loader patches Gerd Hoffmann
2009-10-13 11:06 ` [Qemu-devel] [PATCH 1/4] rom loader: use qemu_strdup Gerd Hoffmann
2009-10-13 11:06 ` [Qemu-devel] [PATCH 2/4] rom loader: make vga+rom loading target specific Gerd Hoffmann
2009-10-13 14:58 ` Blue Swirl [this message]
2009-10-13 15:29 ` Gerd Hoffmann
2009-10-13 16:45 ` Blue Swirl
2009-10-14 7:28 ` Gerd Hoffmann
2009-10-13 22:03 ` Natalia Portillo
2009-10-14 10:21 ` Gerd Hoffmann
2009-10-14 12:37 ` Natalia Portillo
2009-10-13 11:06 ` [Qemu-devel] [PATCH 3/4] vga roms: move loading from pc.c to vga drivers Gerd Hoffmann
2009-10-13 11:06 ` [Qemu-devel] [PATCH 4/4] use rom loader for pc bios Gerd Hoffmann
2009-10-13 19:47 ` Carl-Daniel Hailfinger
2009-10-14 7:31 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2009-10-16 14:04 [Qemu-devel] [PATCH v2 0/4] more rom loader patches Gerd Hoffmann
2009-10-16 14:04 ` [Qemu-devel] [PATCH 2/4] rom loader: make vga+rom loading target specific Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580910130758w47a2b296yd54e3552478c4823@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).