From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N6n86-0000NX-Su
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 10:23:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N6n82-0000MC-5f
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 10:23:06 -0500
Received: from [199.232.76.173] (port=48299 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N6n82-0000M5-2L
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 10:23:02 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:46050)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1N6n81-0001C1-RV
	for qemu-devel@nongnu.org; Sat, 07 Nov 2009 10:23:01 -0500
Received: by yxe26 with SMTP id 26so1611939yxe.4
	for <qemu-devel@nongnu.org>; Sat, 07 Nov 2009 07:23:01 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4AF4ACA5.2090701@redhat.com>
References: <4AF4ACA5.2090701@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 7 Nov 2009 17:22:38 +0200
Message-ID: <f43fc5580911070722n415ea07cr63c2816263234df@mail.gmail.com>
Subject: Re: [Qemu-devel] [sneak preview] major scsi overhaul
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Sat, Nov 7, 2009 at 1:09 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> =C2=A0Hi,
>
> http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/scsi.v6
>
> What is in there?
>
> =C2=A0(1) Reworked scsi data structures. =C2=A0There is a SCSIRequest str=
uct now.
> =C2=A0(2) Restructed emulation in the scsi-disk driver.
> =C2=A0(3) New interface for HBA <=3D> SCSIDevice interaction:
> =C2=A0 =C2=A0 =C2=A0* building on the new SCSIRequest struct.
> =C2=A0 =C2=A0 =C2=A0* the silly read_data/write_data ping-pong game is go=
ne.
> =C2=A0 =C2=A0 =C2=A0* support for scatter lists and zerocopy I/O is there=
.

Cool.

> =C2=A0(4) Added support for the new interface to scsi-disk and scsi-gener=
ic.
> =C2=A0(5) Switched esp and usb-storage to the new interface.
> =C2=A0 =C2=A0 =C2=A0* fixed usb-storage state engine along the way. =C2=
=A0And, no, a
> =C2=A0 =C2=A0 =C2=A0 =C2=A0backport to stable isn't going to happen. =C2=
=A0With the new
> =C2=A0 =C2=A0 =C2=A0 =C2=A0interface state tracking is simpler and easier=
 to get right.
> =C2=A0(6) A bunch of misc fixes and improvements.
>
> What needs to be done?
>
> =C2=A0(1) Better patch descriptions.
> =C2=A0(2) Submit patches to the list for review.
> =C2=A0(3) Switch over lsi to the new interface.
> =C2=A0(4) Zap old interface, killing tons of dead code.
> =C2=A0(5) Final cleanups.

In general the commits look good, there are many obviously correct cleanups=
.

However, what happens to the DPRINTFs, it looks like they are removed
in the process?

You are also moving the compilation to Makefile.hw, which is not
exactly an improvement. Is this needed because of the QEMUIOVector
stuff?