From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8Hd4-0005KP-8A for qemu-devel@nongnu.org; Wed, 11 Nov 2009 13:09:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8Hcz-0005E5-CJ for qemu-devel@nongnu.org; Wed, 11 Nov 2009 13:09:13 -0500 Received: from [199.232.76.173] (port=55906 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8Hcz-0005Dq-1f for qemu-devel@nongnu.org; Wed, 11 Nov 2009 13:09:09 -0500 Received: from mail-gx0-f223.google.com ([209.85.217.223]:53854) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8Hcy-0008RF-P5 for qemu-devel@nongnu.org; Wed, 11 Nov 2009 13:09:08 -0500 Received: by gxk23 with SMTP id 23so1476811gxk.2 for ; Wed, 11 Nov 2009 10:09:08 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20091110205040.GF9052@hall.aurel32.net> From: Blue Swirl Date: Wed, 11 Nov 2009 20:08:48 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: arm, mips and mipsel broken List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, Aurelien Jarno On Wed, Nov 11, 2009 at 7:47 PM, Blue Swirl wrote: > On Wed, Nov 11, 2009 at 1:54 AM, Juan Quintela wrote: >> Blue Swirl wrote: >>> On Tue, Nov 10, 2009 at 10:50 PM, Aurelien Jarno wrote: >>>> Please note that at least qemu-system-arm, qemu-system-mips and >>>> qemu-system-mipsel are broken by this commit: >>> >>> Given that none of the devices touched by the commit should be used by >>> these targets, the breakage comes from just the single new call to >>> qemu_system_reset in vl.c. This means that the reset functions for >>> those boards and devices must be awfully buggy. >>> >>> I think the easiest solution is to surround the call by >>> #if defined(TARGET_I386) || defined(TARGET_PPC) || defined(TARGET_SPARC) >>> #endif >>> until the devices have been fixed. >> >> That call also breaks loadvm from the command line on x86_64. >> If I revert the rest of the patch except that line, I still get breakage >> on rtl8139. > > Sigh. I'll leave only Sparc for now. Sorry for the trouble. > In fact it's easier to revert all commits and commit later one architecture at a time.