From: Blue Swirl <blauwirbel@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Don't leak file descriptors
Date: Mon, 16 Nov 2009 18:21:44 +0200 [thread overview]
Message-ID: <f43fc5580911160821n3ee3780dx38ad25ab7b33af83@mail.gmail.com> (raw)
In-Reply-To: <4B0149C8.7040203@redhat.com>
On Mon, Nov 16, 2009 at 2:47 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 13.11.2009 22:05, schrieb Blue Swirl:
>> On Fri, Nov 13, 2009 at 5:17 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>>> We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
>>> descriptors that don't need to be passed to children to stop this misbehaviour.
>>
>>> - c = accept(s, (struct sockaddr *)&addr, &addrlen);
>>> + c = qemu_accept(s, (struct sockaddr *)&addr, &addrlen);
>>
>> Would it be possible to improve the interface so that no casts are
>> needed for the calling code?
>
> How exactly would you do that? The only way I see to do it would be
> using void*, but I'm not sure if this really is an improvement.
Instead of sockaddr_in vs. sockaddr and the lame casts in between, we
could have QSockAddr which magically works. Or if we only ever use
sockaddr_in, just use that.
next prev parent reply other threads:[~2009-11-16 16:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 15:17 [Qemu-devel] [PATCH] Don't leak file descriptors Kevin Wolf
2009-11-13 15:36 ` Scott Tsai
2009-11-16 2:15 ` Jamie Lokier
2009-11-13 15:41 ` Nathan Froyd
2009-11-13 15:44 ` Kevin Wolf
2009-11-13 21:05 ` Blue Swirl
2009-11-16 12:47 ` Kevin Wolf
2009-11-16 16:21 ` Blue Swirl [this message]
2009-11-16 16:46 ` Avi Kivity
2009-11-16 23:05 ` Jamie Lokier
2009-11-16 23:10 ` Jamie Lokier
2009-11-17 9:12 ` Kevin Wolf
2009-11-17 20:28 ` Blue Swirl
2009-11-16 23:26 ` Anthony Liguori
2009-11-16 23:44 ` Jamie Lokier
2009-11-17 9:00 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580911160821n3ee3780dx38ad25ab7b33af83@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).