From: Blue Swirl <blauwirbel@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Fwd: qemu code review
Date: Wed, 18 Nov 2009 20:43:19 +0200 [thread overview]
Message-ID: <f43fc5580911181043i31b14e92j588fd29921c37482@mail.gmail.com> (raw)
In-Reply-To: <4B03DD07.7090300@redhat.com>
On Wed, Nov 18, 2009 at 1:39 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Hi all,
>
> as Steve suggests, I'm forwarding the list of issues he found to the
> mailing list. I've already looked at a few points in the block code and
> sent patches. If everyone picks up one point, we should get through the
> list quickly. Who volunteers for the TCG ones? ;-)
> In target-sparc/helper.c at line 1277, "name" has not be checked for
> non-NULL
> value before use.
The check is done earlier in sun4m.c, sun4u.c or *-user/main.c.
There's always code like this:
if (!cpu_model)
cpu_model = hwdef->default_cpu_model;
or
if (cpu_model == NULL) {
...
#elif defined(TARGET_SPARC)
#ifdef TARGET_SPARC64
cpu_model = "TI UltraSparc II";
#else
cpu_model = "Fujitsu MB86904";
#endif
before any call to cpu_init().
next prev parent reply other threads:[~2009-11-18 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 11:39 [Qemu-devel] Fwd: qemu code review Kevin Wolf
2009-11-18 16:34 ` malc
2009-11-18 18:43 ` Blue Swirl [this message]
2009-11-18 19:06 ` Stefan Weil
2009-11-19 9:09 ` Kevin Wolf
2009-11-19 18:11 ` Steve Grubb
2009-11-19 18:44 ` [Qemu-devel] [PATCH] e1000: Fix warning from " Stefan Weil
2009-11-19 20:16 ` Ian Molton
2009-11-23 10:44 ` [Qemu-devel] Fwd: qemu " Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580911181043i31b14e92j588fd29921c37482@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).