From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NApVJ-0002pV-9P
	for qemu-devel@nongnu.org; Wed, 18 Nov 2009 13:43:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NApVE-0002or-Ka
	for qemu-devel@nongnu.org; Wed, 18 Nov 2009 13:43:44 -0500
Received: from [199.232.76.173] (port=51694 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NApVE-0002oo-EO
	for qemu-devel@nongnu.org; Wed, 18 Nov 2009 13:43:40 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:48672)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NApVD-0002od-Sh
	for qemu-devel@nongnu.org; Wed, 18 Nov 2009 13:43:40 -0500
Received: by yxe26 with SMTP id 26so1247060yxe.4
	for <qemu-devel@nongnu.org>; Wed, 18 Nov 2009 10:43:39 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B03DD07.7090300@redhat.com>
References: <4B03DD07.7090300@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Wed, 18 Nov 2009 20:43:19 +0200
Message-ID: <f43fc5580911181043i31b14e92j588fd29921c37482@mail.gmail.com>
Subject: Re: [Qemu-devel] Fwd: qemu code review
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Wed, Nov 18, 2009 at 1:39 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Hi all,
>
> as Steve suggests, I'm forwarding the list of issues he found to the
> mailing list. I've already looked at a few points in the block code and
> sent patches. If everyone picks up one point, we should get through the
> list quickly. Who volunteers for the TCG ones? ;-)

> In target-sparc/helper.c at line 1277, "name" has not be checked for
> non-NULL
> value before use.

The check is done earlier in sun4m.c, sun4u.c or *-user/main.c.
There's always code like this:
    if (!cpu_model)
        cpu_model = hwdef->default_cpu_model;
or
    if (cpu_model == NULL) {
...
#elif defined(TARGET_SPARC)
#ifdef TARGET_SPARC64
        cpu_model = "TI UltraSparc II";
#else
        cpu_model = "Fujitsu MB86904";
#endif

before any call to cpu_init().