From: Blue Swirl <blauwirbel@gmail.com>
To: Palle Lyckegaard <palle@lyckegaard.dk>
Cc: "Andreas Färber" <andreas.faerber@web.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PATCH: Building qemu on OpenSolaris 2009.06 (SPARC) host
Date: Mon, 30 Nov 2009 18:56:17 +0200 [thread overview]
Message-ID: <f43fc5580911300856i7d12369btc96f7841ff635a7d@mail.gmail.com> (raw)
In-Reply-To: <alpine.NEB.1.10.0911291956090.13200@otaku.freeshell.org>
On Sun, Nov 29, 2009 at 10:09 PM, Palle Lyckegaard <palle@lyckegaard.dk> wrote:
> On Sun, 29 Nov 2009, Andreas Färber wrote:
>
>> I.e. if unavoidable, instead of #define PSR_XXX 123 one might need to
>> #define TARGET_PSR_XXX 123 and change *all* uses of PSR_XXX to
>> TARGET_PSR_XXX, so that Sun's and QEMU's definitions can live side by side.
>> If your approach or #undef works correctly, that would seem less intrusive,
>> therefore my question.
>>
>
> So far I've located only the definitions FSR_FCC1 and FPSR_FEF as being
> differently defined in qemu and OpenSolaris SPARC.
>
> In order to be as little intrusive as possible I will rework my patch for
> the cpu.h file so
> - where the definitions in qemu and Solaris are equal: guard with an "if
> !defined(CONFIG_SOLARIS)"
> - where the definitions in qemu and Solaris are not equal: add a TARGET_
> prefix to the definitions
It's cleaner just to rename.
PSR_* are also used for Sparc64 %xcc and %icc, so ICC_ or something
similar would be better.
prev parent reply other threads:[~2009-11-30 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 20:39 [Qemu-devel] PATCH: Building qemu on OpenSolaris 2009.06 (SPARC) host Palle Lyckegaard
2009-11-27 19:27 ` Andreas Färber
2009-11-28 20:03 ` Palle Lyckegaard
2009-11-28 23:54 ` Andreas Färber
2009-11-29 12:34 ` Palle Lyckegaard
2009-11-29 14:42 ` Andreas Färber
2009-11-29 20:09 ` Palle Lyckegaard
2009-11-30 16:56 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580911300856i7d12369btc96f7841ff635a7d@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=andreas.faerber@web.de \
--cc=palle@lyckegaard.dk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).