Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

[Blue Swirl <blauwirbel@gmail.com>]

On Sat, Dec 12, 2009 at 6:04 PM, Markus Armbruster <armbru@redhat.com> wrote:
> Blue Swirl <blauwirbel@gmail.com> writes:
>
>> On Wed, Dec 9, 2009 at 11:43 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>> Ian Molton <ian.molton@collabora.co.uk> writes:
>>>
>>>> Markus Armbruster wrote:
>>>>
>>>>> The place for verbose device names is DeviceInfo member desc.  The
>>>>> name should be short & sweet.
>>>>
>>>> Agreed, however...
>>>>
>>>> Why do these (maybe others) get caps in their names? they dont look
>>>> right to me, compared to the others with nice names like usb-serial,
>>>> piix-ide, or cirrus-vga.
>>>>
>>>>> -    sysbus_register_dev("Uni-north main", sizeof(UNINState),
>>>>> +    sysbus_register_dev("Uni-north-main", sizeof(UNINState),
>>>>>                          pci_unin_main_init_device);
>>>>>      pci_qdev_register(&unin_main_pci_host_info);
>>>>> -    sysbus_register_dev("DEC 21154", sizeof(UNINState),
>>>>> +    sysbus_register_dev("DEC-21154", sizeof(UNINState),
>>>>>                          pci_dec_21154_init_device);
>>>>>      pci_qdev_register(&dec_21154_pci_host_info);
>>>>> -    sysbus_register_dev("Uni-north AGP", sizeof(UNINState),
>>>>> +    sysbus_register_dev("Uni-north-AGP", sizeof(UNINState),
>>>>>                          pci_unin_agp_init_device);
>>>>>      pci_qdev_register(&unin_agp_pci_host_info);
>>>>> -    sysbus_register_dev("Uni-north internal", sizeof(UNINState),
>>>>> +    sysbus_register_dev("Uni-north-internal", sizeof(UNINState),
>>>>>                          pci_unin_internal_init_device);
>>>>>      pci_qdev_register(&unin_internal_pci_host_info);
>>>>>  }
>>>
>>> I can downcase them.  Blue Swirl, any objections?
>>>
>>
>> I'd prefer the same names that are used by the device tree, like uni-n
>> and uni-north-agp. Though the bridge is name poorly, just
>> "pci-bridge".
>>
>> For example:
>> http://penguinppc.org/historical/dev-trees-html/imac_400_1.html
>
> If I read that document correctly, we have
>
>    old qdev name               device tree name
>    Uni-north main              uni-n
>    Uni-north AGP               uni-north-agp
>    Uni-north internal          pci
>    DEC 21154                   pci-bridge
>
> Do you want me to respin my patch?  If yes, the best way to make me do
> exactly what you want is to tell me exactly what you want.  In this
> case, tell me the names you want.

'pci' and 'pci-bridge' are too generic, so please respin with these:
   Uni-north main              uni-north
   Uni-north AGP               uni-north-agp
   Uni-north internal          uni-north-pci
   DEC 21154                   dec-21154