From: Blue Swirl <blauwirbel@gmail.com>
To: Artyom Tarasenko <atar4qemu@googlemail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [FOR 0.12 PATCH] scsi-disk: Inquiry with allocation length of CDB < 36 (v3)
Date: Sun, 13 Dec 2009 08:37:47 +0000 [thread overview]
Message-ID: <f43fc5580912130037x347addc3o967db5f94b4d2c7f@mail.gmail.com> (raw)
In-Reply-To: <1260645862-13701-1-git-send-email-atar4qemu@google.com>
On Sat, Dec 12, 2009 at 7:24 PM, Artyom Tarasenko
<atar4qemu@googlemail.com> wrote:
> According to the SCSI-2 specification,
> http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 ,
> "if the allocation length of the command descriptor block (CDB) is too
> small to transfer all of the parameters, the additional length shall
> not be adjusted to reflect the truncation."
> The 36 mandatory bytes of response are written to outbuf, and then
> only the length requested in CDB is transferred.
> ---
> Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
Please leave out "---" between body and SoB in the future, now the SoB
is automagically dropped by git-am.
The patch applies cleanly, but:
CC scsi-disk.o
/src/qemu/hw/scsi-disk.c: In function 'scsi_disk_emulate_inquiry':
/src/qemu/hw/scsi-disk.c:441: error: 'len' undeclared (first use in
this function)
/src/qemu/hw/scsi-disk.c:441: error: (Each undeclared identifier is
reported only once
/src/qemu/hw/scsi-disk.c:441: error: for each function it appears in.)
next prev parent reply other threads:[~2009-12-13 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 19:24 [Qemu-devel] [FOR 0.12 PATCH] scsi-disk: Inquiry with allocation length of CDB < 36 (v3) Artyom Tarasenko
2009-12-13 8:37 ` Blue Swirl [this message]
2009-12-13 10:13 ` [Qemu-devel] " Artyom Tarasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580912130037x347addc3o967db5f94b4d2c7f@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=atar4qemu@googlemail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).