From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJjy1-0006c0-JQ for qemu-devel@nongnu.org; Sun, 13 Dec 2009 03:38:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJjxx-0006Y8-1C for qemu-devel@nongnu.org; Sun, 13 Dec 2009 03:38:13 -0500 Received: from [199.232.76.173] (port=58181 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJjxw-0006Xu-Qe for qemu-devel@nongnu.org; Sun, 13 Dec 2009 03:38:08 -0500 Received: from mail-yw0-f171.google.com ([209.85.211.171]:43776) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NJjxw-0006ai-Mw for qemu-devel@nongnu.org; Sun, 13 Dec 2009 03:38:08 -0500 Received: by ywh1 with SMTP id 1so2052786ywh.18 for ; Sun, 13 Dec 2009 00:38:07 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1260645862-13701-1-git-send-email-atar4qemu@google.com> References: <1260645862-13701-1-git-send-email-atar4qemu@google.com> From: Blue Swirl Date: Sun, 13 Dec 2009 08:37:47 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [FOR 0.12 PATCH] scsi-disk: Inquiry with allocation length of CDB < 36 (v3) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko , qemu-devel On Sat, Dec 12, 2009 at 7:24 PM, Artyom Tarasenko wrote: > According to the SCSI-2 specification, > http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 , > "if the allocation length of the command descriptor block (CDB) is too > small to transfer all of the parameters, the additional length shall > not be adjusted to reflect the truncation." > The 36 mandatory bytes of response are written to outbuf, and then > only the length requested in CDB is transferred. > --- > Signed-off-by: Artyom Tarasenko Please leave out "---" between body and SoB in the future, now the SoB is automagically dropped by git-am. The patch applies cleanly, but: CC scsi-disk.o /src/qemu/hw/scsi-disk.c: In function 'scsi_disk_emulate_inquiry': /src/qemu/hw/scsi-disk.c:441: error: 'len' undeclared (first use in this function) /src/qemu/hw/scsi-disk.c:441: error: (Each undeclared identifier is reported only once /src/qemu/hw/scsi-disk.c:441: error: for each function it appears in.)