From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKE8k-0002iB-Tr
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 11:51:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKE8e-0002fl-RZ
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 11:51:16 -0500
Received: from [199.232.76.173] (port=41180 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKE8e-0002fa-1H
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 11:51:12 -0500
Received: from mail-yw0-f171.google.com ([209.85.211.171]:60066)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NKE8d-0005fy-K4
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 11:51:11 -0500
Received: by ywh1 with SMTP id 1so2946233ywh.18
	for <qemu-devel@nongnu.org>; Mon, 14 Dec 2009 08:51:10 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B261987.6080807@redhat.com>
References: <f43fc5580912130024o169488b6wbb9ca7e656b48975@mail.gmail.com>
	<f43fc5580912130138h246ced19i6d248e4ab6251b4f@mail.gmail.com>
	<4B261987.6080807@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 14 Dec 2009 16:50:50 +0000
Message-ID: <f43fc5580912140850o297e2ea6jef5c7918cc66f5ef@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: -serial stdio broken
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Mon, Dec 14, 2009 at 10:55 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On 12/13/09 10:38, Blue Swirl wrote:
>>
>> On Sun, Dec 13, 2009 at 8:24 AM, Blue Swirl<blauwirbel@gmail.com> =C2=A0=
wrote:
>>>
>>> I guess e1c09175bc00dd8dfb2ad1b26e1858dcdc109b59 or
>>> 998bbd74b9d813b14a3a3b5009a5d5a48c7dce51 broke -serial stdio for all
>>> targets:
>>> qemu -serial stdio -monitor stdio
>
> Oh. =C2=A0It is actually used on the command line. =C2=A0Hmm.
>
> First, you can use '-serial mon:stdio' instead.
>
> Second, with 'qemu -nographic' you don't need to specify this at all beca=
use
> that is the default.
>
> What is gone now is the automagic conversion of '-serial stdio -monitor
> stdio' into '-serial mon:stdio' because I didn't expect people actually
> using that on the command line (see commit message). =C2=A0Also this kind=
 of
> post-processing is pretty horrible thing for the command line parser code=
.
> =C2=A0Thus I would pretty much prefer to not re-introduce this ...

It looks like vl.c was a poor place to do the mux choice. I just
wonder why mux option can't be automatically enabled for stdio in
qemu-char.c:qemu_chr_parse_compat() or somewhere nearby.

> Can you live with one of the alternatives outlined above?

I removed -monitor stdio from all my tests, now they work.