From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NLx10-0000Qv-9e
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 05:58:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NLx0v-0000Nc-AB
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 05:58:25 -0500
Received: from [199.232.76.173] (port=33696 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NLx0u-0000NP-H1
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 05:58:20 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:47762)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NLx0t-0007Xi-Fa
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 05:58:20 -0500
Received: by yxe26 with SMTP id 26so3753983yxe.4
	for <qemu-devel@nongnu.org>; Sat, 19 Dec 2009 02:58:18 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1261134074-11795-2-git-send-email-kraxel@redhat.com>
References: <1261134074-11795-1-git-send-email-kraxel@redhat.com>
	<1261134074-11795-2-git-send-email-kraxel@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 19 Dec 2009 10:57:58 +0000
Message-ID: <f43fc5580912190257i1c7fd33at46853eb5340158be@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/8] Support PCI based option rom loading
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, seabios@seabios.org, qemu-devel@nongnu.org

On Fri, Dec 18, 2009 at 11:01 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> From: Anthony Liguori <aliguori@us.ibm.com>
>
> Currently, we preload option roms into the option rom space in memory. =
=C2=A0This
> prevents DDIM from functioning correctly which severely limits the number
> of roms we can support.
>
> This patch introduces a pci_add_option_rom() which registers the
> PCI_ROM_ADDRESS bar which points to our option rom. =C2=A0It also convert=
s over
> the cirrus vga adapter, the rtl8139, virtio, and the e1000 to use this
> new mechanism.

This means that the VGA roms are now visible for all targets, not just
when rom_enable_driver_roms is true. I'm not opposing this, but it may
create regressions.