From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NLy4t-0002YI-6F
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 07:06:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NLy4o-0002X2-4U
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 07:06:30 -0500
Received: from [199.232.76.173] (port=49085 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NLy4n-0002Wv-Sc
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 07:06:25 -0500
Received: from mail-yw0-f171.google.com ([209.85.211.171]:47815)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NLy4n-0004zJ-De
	for qemu-devel@nongnu.org; Sat, 19 Dec 2009 07:06:25 -0500
Received: by ywh1 with SMTP id 1so3675422ywh.18
	for <qemu-devel@nongnu.org>; Sat, 19 Dec 2009 04:06:24 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1261134074-11795-5-git-send-email-kraxel@redhat.com>
References: <1261134074-11795-1-git-send-email-kraxel@redhat.com>
	<1261134074-11795-5-git-send-email-kraxel@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 19 Dec 2009 12:06:04 +0000
Message-ID: <f43fc5580912190406q6f6003aat42b0a5198e5aa07@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 4/8] fw_cfg: add API for file transfer.
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

On Fri, Dec 18, 2009 at 11:01 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> This patch adds a file transfer interface to fw_cfg. =C2=A0Intended to be
> used for passing non-pci option roms and vgabios to seabios. =C2=A0Namesp=
ace
> is modeled after the existing cbfs filesystem support in seabios.
>
> Reading the new FW_CFG_FILE_DIR entry returns a file list.
> Fields there are in network byte order (aka bigendian).

The 16 bit selector for other cases is in little endian order. Please
use LE for consistency.

> + =C2=A0 =C2=A0fprintf(stderr, "%s: #%d: %s (%d bytes)\n", __FUNCTION__,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0index, s->files->f[index].name=
, len);

No.