From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NMJa0-0000Nz-8c for qemu-devel@nongnu.org; Sun, 20 Dec 2009 06:04:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NMJZv-0000KV-J3 for qemu-devel@nongnu.org; Sun, 20 Dec 2009 06:04:03 -0500 Received: from [199.232.76.173] (port=39647 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMJZv-0000KM-Ba for qemu-devel@nongnu.org; Sun, 20 Dec 2009 06:03:59 -0500 Received: from mail-yw0-f171.google.com ([209.85.211.171]:51349) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NMJZu-0000Yf-Rl for qemu-devel@nongnu.org; Sun, 20 Dec 2009 06:03:58 -0500 Received: by ywh1 with SMTP id 1so4119089ywh.18 for ; Sun, 20 Dec 2009 03:03:58 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20091219231120.GA32531@volta.aurel32.net> From: Blue Swirl Date: Sun, 20 Dec 2009 11:03:38 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 0/5] tcg conditional set, round 4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson On Sat, Dec 19, 2009 at 11:43 PM, malc wrote: > On Sun, 20 Dec 2009, Aurelien Jarno wrote: > >> On Sat, Dec 19, 2009 at 10:52:52AM -0800, Richard Henderson wrote: >> > Changes from round 3: >> > >> > =C2=A0* Drop movcond for now. >> > =C2=A0* Only use movzbl and not xor in setcond. >> > >> > >> >> Thanks for the update, it looks like ready, I only have cosmetic or >> minor comments. See my comments in the individual patches >> >> I think we should commit it now, but wait a bit until it is implemented >> in all TCG targets to use this new ops. We can circulate patches in the >> meanwhile. >> > > This doesn't really parse for me, but anyways, i've added setcond/setcond= 2 > to PPC/PPC64 so no objections from my side [1]. > > Blue Swirl? No objection, though I have no idea if this is useful.