From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMPAu-000429-0t
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 12:02:32 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMPAp-0003zJ-5G
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 12:02:31 -0500
Received: from [199.232.76.173] (port=51321 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMPAo-0003zB-UA
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 12:02:26 -0500
Received: from mail-gx0-f223.google.com ([209.85.217.223]:46801)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NMPAo-00016h-Hl
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 12:02:26 -0500
Received: by gxk23 with SMTP id 23so4783418gxk.2
	for <qemu-devel@nongnu.org>; Sun, 20 Dec 2009 09:02:25 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B2E4409.4050809@codemonkey.ws>
References: <1261134074-11795-1-git-send-email-kraxel@redhat.com>
	<1261134074-11795-2-git-send-email-kraxel@redhat.com>
	<f43fc5580912190257i1c7fd33at46853eb5340158be@mail.gmail.com>
	<4B2E4409.4050809@codemonkey.ws>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 20 Dec 2009 17:02:05 +0000
Message-ID: <f43fc5580912200902u623ec921yde71e9a5cd08fa8@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/8] Support PCI based option rom loading
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, seabios@seabios.org, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Sun, Dec 20, 2009 at 3:34 PM, Anthony Liguori <anthony@codemonkey.ws> wr=
ote:
> Blue Swirl wrote:
>>
>> On Fri, Dec 18, 2009 at 11:01 AM, Gerd Hoffmann <kraxel@redhat.com> wrot=
e:
>>
>>>
>>> From: Anthony Liguori <aliguori@us.ibm.com>
>>>
>>> Currently, we preload option roms into the option rom space in memory.
>>> =C2=A0This
>>> prevents DDIM from functioning correctly which severely limits the numb=
er
>>> of roms we can support.
>>>
>>> This patch introduces a pci_add_option_rom() which registers the
>>> PCI_ROM_ADDRESS bar which points to our option rom. =C2=A0It also conve=
rts
>>> over
>>> the cirrus vga adapter, the rtl8139, virtio, and the e1000 to use this
>>> new mechanism.
>>>
>>
>> This means that the VGA roms are now visible for all targets, not just
>> when rom_enable_driver_roms is true. I'm not opposing this, but it may
>> create regressions.
>>
>
> This is pretty normal on bare metal though, no? =C2=A0I thought a lot of =
non-x86
> systems actually use x86 emulators specifically to enable support for the=
se
> roms.

I think so too, but ROM loading was first introduced with
rom_enable_driver_roms mechanism just for cases like this.

But if there are no regressions, rom_enable_driver_roms mechanism
could be removed.