From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NN9oh-000175-PF
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:50:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NN9od-00014K-2x
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:50:43 -0500
Received: from [199.232.76.173] (port=34865 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NN9oc-000149-Jh
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:50:38 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:63564)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NN9ob-0000Af-Rd
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:50:38 -0500
Received: by yxe26 with SMTP id 26so6214770yxe.4
	for <qemu-devel@nongnu.org>; Tue, 22 Dec 2009 10:50:35 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1261273167-3240-10-git-send-email-kirill@shutemov.name>
References: <1261273167-3240-1-git-send-email-kirill@shutemov.name>
	<1261273167-3240-2-git-send-email-kirill@shutemov.name>
	<1261273167-3240-3-git-send-email-kirill@shutemov.name>
	<1261273167-3240-4-git-send-email-kirill@shutemov.name>
	<1261273167-3240-5-git-send-email-kirill@shutemov.name>
	<1261273167-3240-6-git-send-email-kirill@shutemov.name>
	<1261273167-3240-7-git-send-email-kirill@shutemov.name>
	<1261273167-3240-8-git-send-email-kirill@shutemov.name>
	<1261273167-3240-9-git-send-email-kirill@shutemov.name>
	<1261273167-3240-10-git-send-email-kirill@shutemov.name>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Tue, 22 Dec 2009 18:50:15 +0000
Message-ID: <f43fc5580912221050v348866dbi68fdf8acaee5a1f3@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning with
	_FORTIFY_SOURCE
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: qemu-devel@nongnu.org

On Sun, Dec 20, 2009 at 1:39 AM, Kirill A. Shutemov
<kirill@shutemov.name> wrote:
> =C2=A0CC =C2=A0 =C2=A0net/slirp.o
> cc1: warnings being treated as errors
> net/slirp.c: In function 'slirp_smb_cleanup':
> net/slirp.c:470: error: ignoring return value of 'system', declared with =
attribute warn_unused_result
> make: *** [net/slirp.o] Error 1
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
> =C2=A0net/slirp.c | =C2=A0 =C2=A07 ++++++-
> =C2=A01 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 3f91c4b..1f16814 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -464,10 +464,15 @@ int net_slirp_redir(const char *redir_str)
> =C2=A0static void slirp_smb_cleanup(SlirpState *s)
> =C2=A0{
> =C2=A0 =C2=A0 char cmd[128];
> + =C2=A0 =C2=A0int ret;
>
> =C2=A0 =C2=A0 if (s->smb_dir[0] !=3D '\0') {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 snprintf(cmd, sizeof(cmd), "rm -rf %s", s->sm=
b_dir);
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0system(cmd);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D system(cmd);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret) {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0qemu_error("'%s' failed. Error=
 code: %d\n", cmd, ret);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* abort() ? */

This is not correct.

- system() returns -1 on error and the command exit status otherwise,
which may also be nonzero.
- the exit status should be retrieved with WEXITSTATUS() macro, or in
case of error via errno.
- in no case abort() is warranted for smb cleanup.