From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NNA1P-0003SA-0A
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:03:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NNA1K-0003NM-BE
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:03:50 -0500
Received: from [199.232.76.173] (port=34287 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NNA1K-0003N3-5H
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:03:46 -0500
Received: from mail-gx0-f223.google.com ([209.85.217.223]:53089)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NNA1J-0001lb-RF
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:03:45 -0500
Received: by gxk23 with SMTP id 23so6790504gxk.2
	for <qemu-devel@nongnu.org>; Tue, 22 Dec 2009 11:03:45 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1261273167-3240-11-git-send-email-kirill@shutemov.name>
References: <1261273167-3240-1-git-send-email-kirill@shutemov.name>
	<1261273167-3240-3-git-send-email-kirill@shutemov.name>
	<1261273167-3240-4-git-send-email-kirill@shutemov.name>
	<1261273167-3240-5-git-send-email-kirill@shutemov.name>
	<1261273167-3240-6-git-send-email-kirill@shutemov.name>
	<1261273167-3240-7-git-send-email-kirill@shutemov.name>
	<1261273167-3240-8-git-send-email-kirill@shutemov.name>
	<1261273167-3240-9-git-send-email-kirill@shutemov.name>
	<1261273167-3240-10-git-send-email-kirill@shutemov.name>
	<1261273167-3240-11-git-send-email-kirill@shutemov.name>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Tue, 22 Dec 2009 19:03:25 +0000
Message-ID: <f43fc5580912221103v4dd68e92q973ae8742549ff85@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 11/18] usb-linux.c: fix warning with
	_FORTIFY_SOURCE
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: qemu-devel@nongnu.org

On Sun, Dec 20, 2009 at 1:39 AM, Kirill A. Shutemov
<kirill@shutemov.name> wrote:
> =C2=A0CC =C2=A0 =C2=A0usb-linux.o
> cc1: warnings being treated as errors
> usb-linux.c: In function 'usb_host_read_file':
> usb-linux.c:1204: error: ignoring return value of 'fgets', declared with =
attribute warn_unused_result
> make: *** [usb-linux.o] Error 1
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
> =C2=A0usb-linux.c | =C2=A0 =C2=A07 +++++--
> =C2=A01 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index 88728e9..67bfa7a 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -1201,9 +1201,12 @@ static int usb_host_read_file(char *line, size_t l=
ine_size, const char *device_f
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0device_file);
> =C2=A0 =C2=A0 f =3D fopen(filename, "r");
> =C2=A0 =C2=A0 if (f) {
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0fgets(line, line_size, f);
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if (fgets(line, line_size, f))
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D 1;
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0else
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D 0;
> +
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 fclose(f);
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D 1;

Considering the return values of fgets() and usb_host_read_file(),
this patch looks OK except for the CODING_STYLE violation.