From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NNAJG-0002lM-Q6
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:22:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NNAJC-0002fM-7V
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:22:18 -0500
Received: from [199.232.76.173] (port=47511 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NNAJC-0002fH-1k
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:22:14 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:56215)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NNAJB-0003jf-VG
	for qemu-devel@nongnu.org; Tue, 22 Dec 2009 14:22:14 -0500
Received: by yxe26 with SMTP id 26so6245701yxe.4
	for <qemu-devel@nongnu.org>; Tue, 22 Dec 2009 11:22:13 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1261273167-3240-12-git-send-email-kirill@shutemov.name>
References: <1261273167-3240-1-git-send-email-kirill@shutemov.name>
	<1261273167-3240-4-git-send-email-kirill@shutemov.name>
	<1261273167-3240-5-git-send-email-kirill@shutemov.name>
	<1261273167-3240-6-git-send-email-kirill@shutemov.name>
	<1261273167-3240-7-git-send-email-kirill@shutemov.name>
	<1261273167-3240-8-git-send-email-kirill@shutemov.name>
	<1261273167-3240-9-git-send-email-kirill@shutemov.name>
	<1261273167-3240-10-git-send-email-kirill@shutemov.name>
	<1261273167-3240-11-git-send-email-kirill@shutemov.name>
	<1261273167-3240-12-git-send-email-kirill@shutemov.name>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Tue, 22 Dec 2009 19:21:53 +0000
Message-ID: <f43fc5580912221121w48c99b90j5b487c83f02b8ccc@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 12/18] savevm.c: fix warning with
	_FORTIFY_SOURCE
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: qemu-devel@nongnu.org

On Sun, Dec 20, 2009 at 1:39 AM, Kirill A. Shutemov
<kirill@shutemov.name> wrote:
> =C2=A0CC =C2=A0 =C2=A0savevm.o
> cc1: warnings being treated as errors
> savevm.c: In function 'file_put_buffer':
> savevm.c:342: error: ignoring return value of 'fwrite', declared with att=
ribute warn_unused_result
> make: *** [savevm.o] Error 1
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
> =C2=A0savevm.c | =C2=A0 =C2=A03 +--
> =C2=A01 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index aefe052..829f735 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -339,8 +339,7 @@ static int file_put_buffer(void *opaque, const uint8_=
t *buf,
> =C2=A0{
> =C2=A0 =C2=A0 QEMUFileStdio *s =3D opaque;
> =C2=A0 =C2=A0 fseek(s->stdio_file, pos, SEEK_SET);
> - =C2=A0 =C2=A0fwrite(buf, 1, size, s->stdio_file);
> - =C2=A0 =C2=A0return size;
> + =C2=A0 =C2=A0return fwrite(buf, 1, size, s->stdio_file);

Looks OK.

The callers do not handle partial writes, but that's because the
return value is not used correctly. They should be fixed some time.

We are truncating size_t to int, but that is OK given that the input
size is also int. The interfaces should be cleaned up to use
size_t/ssize_t later.