From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NNC29-0003AK-Uz for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:12:46 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NNC25-00036u-Ae for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:12:45 -0500 Received: from [199.232.76.173] (port=44117 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNC25-00036l-8K for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:12:41 -0500 Received: from mail-yx0-f188.google.com ([209.85.210.188]:40387) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NNC24-0005wa-U8 for qemu-devel@nongnu.org; Tue, 22 Dec 2009 16:12:41 -0500 Received: by yxe26 with SMTP id 26so6344031yxe.4 for ; Tue, 22 Dec 2009 13:12:40 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1261273167-3240-14-git-send-email-kirill@shutemov.name> References: <1261273167-3240-1-git-send-email-kirill@shutemov.name> <1261273167-3240-6-git-send-email-kirill@shutemov.name> <1261273167-3240-7-git-send-email-kirill@shutemov.name> <1261273167-3240-8-git-send-email-kirill@shutemov.name> <1261273167-3240-9-git-send-email-kirill@shutemov.name> <1261273167-3240-10-git-send-email-kirill@shutemov.name> <1261273167-3240-11-git-send-email-kirill@shutemov.name> <1261273167-3240-12-git-send-email-kirill@shutemov.name> <1261273167-3240-13-git-send-email-kirill@shutemov.name> <1261273167-3240-14-git-send-email-kirill@shutemov.name> From: Blue Swirl Date: Tue, 22 Dec 2009 21:12:20 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 14/18] vl.c: fix warning with _FORTIFY_SOURCE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" Cc: qemu-devel@nongnu.org On Sun, Dec 20, 2009 at 1:39 AM, Kirill A. Shutemov wrote: > =C2=A0CC =C2=A0 =C2=A0i386-softmmu/vl.o > cc1: warnings being treated as errors > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value o= f 'write', declared with attribute warn_unused_result > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'main': > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:5774: error: ignoring return value o= f 'write', declared with attribute warn_unused_result > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:6064: error: ignoring return value o= f 'chdir', declared with attribute warn_unused_result > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:6083: error: ignoring return value o= f 'chdir', declared with attribute warn_unused_result > make[1]: *** [vl.o] Error 1 > > Signed-off-by: Kirill A. Shutemov > --- > =C2=A0vl.c | =C2=A0 15 +++++++++++---- > =C2=A01 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/vl.c b/vl.c > index e606903..60a2c5e 100644 > --- a/vl.c > +++ b/vl.c > @@ -3383,7 +3383,11 @@ static void qemu_event_increment(void) > =C2=A0 =C2=A0 if (io_thread_fd =3D=3D -1) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 return; > > - =C2=A0 =C2=A0write(io_thread_fd, &byte, sizeof(byte)); > + =C2=A0 =C2=A0if (write(io_thread_fd, &byte, sizeof(byte)) !=3D sizeof(b= yte)){ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0fprintf(stderr, "qemu_event_increment: write= () filed: %s\n", > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0strerror(errno))= ; > + =C2=A0 =C2=A0 =C2=A0 =C2=A0exit (1); > + =C2=A0 =C2=A0} > =C2=A0} > > =C2=A0static void qemu_event_read(void *opaque) > @@ -5767,7 +5771,8 @@ int main(int argc, char **argv, char **envp) > =C2=A0#ifndef _WIN32 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (daemonize) { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 uint8_t status =3D 1; > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0write(fds[1], &status, 1); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (write(fds[1], &status, 1) = !=3D 1) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0perror("write()"= ); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else > =C2=A0#endif > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fprintf(stderr, "Could not acqu= ire pid file: %s\n", strerror(errno)); > @@ -6064,7 +6069,8 @@ int main(int argc, char **argv, char **envp) > =C2=A0 =C2=A0 =C2=A0 =C2=A0if (len !=3D 1) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0exit(1); > > - =C2=A0 =C2=A0 =C2=A0 chdir("/"); > + =C2=A0 =C2=A0 =C2=A0 if (chdir("/")) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0exit(1); > =C2=A0 =C2=A0 =C2=A0 =C2=A0TFR(fd =3D qemu_open("/dev/null", O_RDWR)); > =C2=A0 =C2=A0 =C2=A0 =C2=A0if (fd =3D=3D -1) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0exit(1); > @@ -6083,7 +6089,8 @@ int main(int argc, char **argv, char **envp) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fprintf(stderr, "chroot failed\= n"); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 exit(1); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > - =C2=A0 =C2=A0 =C2=A0 =C2=A0chdir("/"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0if (chdir("/")) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0exit(1); Can't comment much on write() parts. chdir() checks are OK, except an error message would be in order.