From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUmxS-00086L-NS for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:03:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUmxO-0007xb-0v for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:03:18 -0500 Received: from [199.232.76.173] (port=48738 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUmxN-0007xK-TD for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:03:13 -0500 Received: from mail-pw0-f43.google.com ([209.85.160.43]:52521) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUmxN-0004W7-BJ for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:03:13 -0500 Received: by pwj11 with SMTP id 11so2839892pwj.2 for ; Tue, 12 Jan 2010 12:03:12 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Blue Swirl Date: Tue, 12 Jan 2010 20:02:52 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 0/5] tcg-sparc improvements List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Mon, Jan 11, 2010 at 7:22 PM, Richard Henderson wrote: > As noticed elsewhere on the list mulu2_i32 is missing. =C2=A0Which led > me to notice that add2_i32 and sub2_i32 were also missing and also > led me to notice that division was incorrectly implemented. > > My initial implementation of 32-bit division copied the existing practice > of using the 64-bit division insns for sparcv9, with proper sign/zero > extensions on the input operands. =C2=A0But that required extra temporari= es > and quickly got ugly. =C2=A0In the end I thought it was clearer to simply= use > the 32-bit division insns unconditionally. > > That excercise, however, made me notice that 32-bit extension was not > special-cased, leading to the final patch. Thanks, applied all (4/5 with your fix).