From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUnAF-0006b1-EQ for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:16:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUnAB-0006ZW-1F for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:16:31 -0500 Received: from [199.232.76.173] (port=49736 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUnAA-0006ZT-Rp for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:16:26 -0500 Received: from mail-pz0-f188.google.com ([209.85.222.188]:43433) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUnAA-00084F-IU for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:16:26 -0500 Received: by pzk26 with SMTP id 26so13280883pzk.4 for ; Tue, 12 Jan 2010 12:16:25 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1263297526-13518-5-git-send-email-agraf@suse.de> References: <1263297526-13518-1-git-send-email-agraf@suse.de> <1263297526-13518-5-git-send-email-agraf@suse.de> From: Blue Swirl Date: Tue, 12 Jan 2010 20:16:05 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 4/9] PPC: Include dump of lspci -nn on real G5 Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: QEMU Developers , Aurelien Jarno On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf wrote: > To ease debugging and to know what we're lacking, I found it really useful to > have an lspci dump of a real U3 based G5 around. So I added a comment for it. > > If people don't think it's important enough to include this information in the > sources, just don't apply this patch. I think it would be useful, but the right place would be in ppc_newworld.c, because that is where the PCI bus is populated. For unin_pci.c, an interesting reference would be a link to the data sheet.