From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUnbC-0004RY-LW for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:44:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUnb7-0004Oo-MD for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:44:22 -0500 Received: from [199.232.76.173] (port=43633 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUnb7-0004Oh-C9 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:44:17 -0500 Received: from mail-px0-f189.google.com ([209.85.216.189]:32882) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUnb6-0006wE-Vx for qemu-devel@nongnu.org; Tue, 12 Jan 2010 15:44:17 -0500 Received: by pxi27 with SMTP id 27so2874684pxi.4 for ; Tue, 12 Jan 2010 12:44:15 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <319F8846-C22A-4095-B7E2-8529450155C1@suse.de> References: <1263297526-13518-1-git-send-email-agraf@suse.de> <1263297526-13518-5-git-send-email-agraf@suse.de> <319F8846-C22A-4095-B7E2-8529450155C1@suse.de> From: Blue Swirl Date: Tue, 12 Jan 2010 20:43:55 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 4/9] PPC: Include dump of lspci -nn on real G5 Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: QEMU Developers , Aurelien Jarno On Tue, Jan 12, 2010 at 8:35 PM, Alexander Graf wrote: > > On 12.01.2010, at 21:16, Blue Swirl wrote: > >> On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf wrote: >>> To ease debugging and to know what we're lacking, I found it really useful to >>> have an lspci dump of a real U3 based G5 around. So I added a comment for it. >>> >>> If people don't think it's important enough to include this information in the >>> sources, just don't apply this patch. >> >> I think it would be useful, but the right place would be in >> ppc_newworld.c, because that is where the PCI bus is populated. > > Hum, that file is pretty cluttered already. How about we create a Documentation subdir in qemu that contains information about various devices? Nobody reads documentation :) There's plenty of room near line 50, that's where I have put references in other files. >> For unin_pci.c, an interesting reference would be a link to the data sheet. > > I'm not aware of any. The only real specification I know of is for the U4. Then U4 may be a more interesting machine to be implemented than U3, at least if there are more documented devices or fewer critical undocumented devices.