From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NW4Jf-0003aS-Kr for qemu-devel@nongnu.org; Sat, 16 Jan 2010 03:47:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NW4Jc-0003a4-Qx for qemu-devel@nongnu.org; Sat, 16 Jan 2010 03:47:31 -0500 Received: from [199.232.76.173] (port=57464 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NW4Jb-0003Zu-Gg for qemu-devel@nongnu.org; Sat, 16 Jan 2010 03:47:27 -0500 Received: from mail-px0-f189.google.com ([209.85.216.189]:45376) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NW4Jb-0000Ck-36 for qemu-devel@nongnu.org; Sat, 16 Jan 2010 03:47:27 -0500 Received: by pxi27 with SMTP id 27so1000036pxi.4 for ; Sat, 16 Jan 2010 00:47:26 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1263595050-17791-1-git-send-email-atar4qemu@google.com> From: Blue Swirl Date: Sat, 16 Jan 2010 08:47:06 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: sparc32 do not clear interrupts when masking List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko Cc: qemu-devel@nongnu.org, Artyom Tarasenko On Sat, Jan 16, 2010 at 8:16 AM, Blue Swirl wrote: > On Fri, Jan 15, 2010 at 10:37 PM, Artyom Tarasenko > wrote: >> Don't clear interrupts on disabling, because >> * Sun4M_SystemArchitecture_edited2.pdf doesn't describe >> =C2=A0that masking or un-masking IRQ shall clear pending ones. >> >> * Field tests also show that SPARCstation-20 doesn't >> =C2=A0clear them. > > Awesome work! > >> * The patch makes Solaris 2.5.1/2.6 boot ~1500 times >> =C2=A0faster (~20 seconds instead of ~8 hours) > > Unfortunately there is some problem with the patch (or more likely > there is some other bug that this uncovers), because all my Linux test > now panic. NetBSD and OpenBSD are unaffected. > > For example, sparc-test: > eth0: LANCE 52:54:00:12:34:56 > esp0: no command in esp_handle() > Kernel panic - not syncing: esp_handle: current_SC =3D=3D penguin within = interrupt! > =C2=A0<0>Press L1-A to return to the boot prom > > The bug may be in ESP interrupt handling (or in the interrupt chain > between ESP, DMA controller and interrupt controller) as the panic > always happens in ESP probe. In fact the bug was that OpenBIOS didn't clear ESP interrupts after issuing commands, so the IRQ line was left raised which confused Linux.