From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NW4fr-0005Gj-Rw
	for qemu-devel@nongnu.org; Sat, 16 Jan 2010 04:10:27 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NW4fn-0005G9-BO
	for qemu-devel@nongnu.org; Sat, 16 Jan 2010 04:10:27 -0500
Received: from [199.232.76.173] (port=55140 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NW4fn-0005G6-9K
	for qemu-devel@nongnu.org; Sat, 16 Jan 2010 04:10:23 -0500
Received: from mail-pw0-f43.google.com ([209.85.160.43]:64432)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NW4fm-0007GJ-Vd
	for qemu-devel@nongnu.org; Sat, 16 Jan 2010 04:10:23 -0500
Received: by pwj11 with SMTP id 11so866928pwj.2
	for <qemu-devel@nongnu.org>; Sat, 16 Jan 2010 01:10:22 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <f43fc5581001160047t4beec155re7aee40f9890cf54@mail.gmail.com>
References: <1263595050-17791-1-git-send-email-atar4qemu@google.com>
	<f43fc5581001160016n42a154bt510edf2747d88d95@mail.gmail.com>
	<f43fc5581001160047t4beec155re7aee40f9890cf54@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 16 Jan 2010 09:10:02 +0000
Message-ID: <f43fc5581001160110n7d8e2bc1q7f51fbada5ffb8e1@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: sparc32 do not clear interrupts when masking
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Artyom Tarasenko <atar4qemu@googlemail.com>
Cc: qemu-devel@nongnu.org, Artyom Tarasenko <atar4qemu@gmail.com>

On Sat, Jan 16, 2010 at 8:47 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Sat, Jan 16, 2010 at 8:16 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Fri, Jan 15, 2010 at 10:37 PM, Artyom Tarasenko
>> <atar4qemu@googlemail.com> wrote:
>>> Don't clear interrupts on disabling, because
>>> * Sun4M_SystemArchitecture_edited2.pdf doesn't describe
>>> =C2=A0that masking or un-masking IRQ shall clear pending ones.
>>>
>>> * Field tests also show that SPARCstation-20 doesn't
>>> =C2=A0clear them.
>>
>> Awesome work!
>>
>>> * The patch makes Solaris 2.5.1/2.6 boot ~1500 times
>>> =C2=A0faster (~20 seconds instead of ~8 hours)
>>
>> Unfortunately there is some problem with the patch (or more likely
>> there is some other bug that this uncovers), because all my Linux test
>> now panic. NetBSD and OpenBSD are unaffected.
>>
>> For example, sparc-test:
>> eth0: LANCE 52:54:00:12:34:56
>> esp0: no command in esp_handle()
>> Kernel panic - not syncing: esp_handle: current_SC =3D=3D penguin within=
 interrupt!
>> =C2=A0<0>Press L1-A to return to the boot prom
>>
>> The bug may be in ESP interrupt handling (or in the interrupt chain
>> between ESP, DMA controller and interrupt controller) as the panic
>> always happens in ESP probe.
>
> In fact the bug was that OpenBIOS didn't clear ESP interrupts after
> issuing commands, so the IRQ line was left raised which confused
> Linux.
>

Thanks, applied. I fixed the OpenBIOS bug and updated images in pc-bios.