[Qemu-devel] [PATCHv2 0/3] rwhandler: introduce and switch pci_host to it

[Qemu-devel] [PATCHv2 0/3] rwhandler: introduce and switch pci_host to it

[Michael S. Tsirkin]

Alexander, so I assume the following patchset should be enough for you
to implement u3 support, simply by creating your own rwhandler, and
using pci_data_read/write directly there. I have pushed it to a
temporary branch in my tree:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git rwhandler

Paul, any comments on this approach?

I'll push this to my pci tree if this turns out to be helpful.
Hope this helps, and sorry about the churn.

Michael S. Tsirkin (3):
  bwap: add qemu_bswap helper
  rwhandler: simplified way to register for mem/io
  pci_host: rewrite using rwhandler

 Makefile.target        |    1 +
 bswap.h                |    6 ++
 hw/pci_host.c          |  172 +++++++++++++++++++----------------------------
 hw/pci_host.h          |    4 +
 hw/pci_host_template.h |  109 ------------------------------
 rwhandler.c            |   91 +++++++++++++++++++++++++
 rwhandler.h            |   27 ++++++++
 7 files changed, 199 insertions(+), 211 deletions(-)
 delete mode 100644 hw/pci_host_template.h
 create mode 100644 rwhandler.c
 create mode 100644 rwhandler.h

[Qemu-devel] Re: [PATCHv2 0/3] rwhandler: introduce and switch pci_host to it

[Blue Swirl]

On Mon, Jan 18, 2010 at 10:56 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> Alexander, so I assume the following patchset should be enough for you
> to implement u3 support, simply by creating your own rwhandler, and
> using pci_data_read/write directly there. I have pushed it to a
> temporary branch in my tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git rwhandler
>
> Paul, any comments on this approach?
>
> I'll push this to my pci tree if this turns out to be helpful.
> Hope this helps, and sorry about the churn.

I proposed earlier something similar for MMIO. The thread could be interesting:
http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00095.html

[Qemu-devel] Re: [PATCHv2 0/3] rwhandler: introduce and switch pci_host to it

[Michael S. Tsirkin]

On Mon, Jan 18, 2010 at 05:50:35PM +0000, Blue Swirl wrote:
> On Mon, Jan 18, 2010 at 10:56 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Alexander, so I assume the following patchset should be enough for you
> > to implement u3 support, simply by creating your own rwhandler, and
> > using pci_data_read/write directly there. I have pushed it to a
> > temporary branch in my tree:
> > git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git rwhandler
> >
> > Paul, any comments on this approach?
> >
> > I'll push this to my pci tree if this turns out to be helpful.
> > Hope this helps, and sorry about the churn.
> 
> I proposed earlier something similar for MMIO. The thread could be interesting:
> http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00095.html

IIUC that patch seems to do much more, and also seems to involve all io?
This one is just a library that devices can use. Intended users are not
performance-critical like pci config.

-- 
MST

[Qemu-devel] Re: [PATCHv2 0/3] rwhandler: introduce and switch pci_host to it

[Michael S. Tsirkin]

On Mon, Jan 18, 2010 at 07:53:25PM +0200, Michael S. Tsirkin wrote:
> On Mon, Jan 18, 2010 at 05:50:35PM +0000, Blue Swirl wrote:
> > On Mon, Jan 18, 2010 at 10:56 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > Alexander, so I assume the following patchset should be enough for you
> > > to implement u3 support, simply by creating your own rwhandler, and
> > > using pci_data_read/write directly there. I have pushed it to a
> > > temporary branch in my tree:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git rwhandler
> > >
> > > Paul, any comments on this approach?
> > >
> > > I'll push this to my pci tree if this turns out to be helpful.
> > > Hope this helps, and sorry about the churn.
> > 
> > I proposed earlier something similar for MMIO. The thread could be interesting:
> > http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00095.html
> 
> IIUC that patch seems to do much more, and also seems to involve all io?
> This one is just a library that devices can use. Intended users are not
> performance-critical like pci config.

To put it in other words: could you please be more explicit please?  I
failed to see the relevance ...


-- 
MST

[Qemu-devel] Re: [PATCHv2 0/3] rwhandler: introduce and switch pci_host to it

[Blue Swirl]

On Mon, Jan 18, 2010 at 7:41 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Mon, Jan 18, 2010 at 07:53:25PM +0200, Michael S. Tsirkin wrote:
>> On Mon, Jan 18, 2010 at 05:50:35PM +0000, Blue Swirl wrote:
>> > On Mon, Jan 18, 2010 at 10:56 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> > > Alexander, so I assume the following patchset should be enough for you
>> > > to implement u3 support, simply by creating your own rwhandler, and
>> > > using pci_data_read/write directly there. I have pushed it to a
>> > > temporary branch in my tree:
>> > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git rwhandler
>> > >
>> > > Paul, any comments on this approach?
>> > >
>> > > I'll push this to my pci tree if this turns out to be helpful.
>> > > Hope this helps, and sorry about the churn.
>> >
>> > I proposed earlier something similar for MMIO. The thread could be interesting:
>> > http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00095.html
>>
>> IIUC that patch seems to do much more, and also seems to involve all io?
>> This one is just a library that devices can use. Intended users are not
>> performance-critical like pci config.
>
> To put it in other words: could you please be more explicit please?  I
> failed to see the relevance ...

Well, I thought the stuff I proposed earlier may be useful for
comparison. It was also opt-in like yours, by the way.

Also the end result that Paul wasn't interested in my patch may (or
may not) be relevant with yours too.