From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NY0TD-0000qd-Vs for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:05:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NY0T8-0000lY-Pc for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:05:23 -0500 Received: from [199.232.76.173] (port=38721 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NY0T8-0000lG-Hg for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:05:18 -0500 Received: from mail-pw0-f43.google.com ([209.85.160.43]:64087) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NY0T8-00020W-38 for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:05:18 -0500 Received: by pwj11 with SMTP id 11so117930pwj.2 for ; Thu, 21 Jan 2010 09:05:16 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20100121115239.0a8ea7ab@doriath> References: <1264005551-12989-1-git-send-email-lcapitulino@redhat.com> <20100120161114.3bfdebca@doriath> <20100121115239.0a8ea7ab@doriath> From: Blue Swirl Date: Thu, 21 Jan 2010 17:04:56 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, mst@redhat.com, Markus Armbruster , qemu-devel@nongnu.org On Thu, Jan 21, 2010 at 1:52 PM, Luiz Capitulino w= rote: > On Wed, 20 Jan 2010 19:22:48 +0000 > Blue Swirl wrote: > >> On Wed, Jan 20, 2010 at 6:11 PM, Luiz Capitulino wrote: >> > On Wed, 20 Jan 2010 18:57:56 +0100 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >> >> >> >> > =C2=A0Hi, >> >> > >> >> > =C2=A0This new version addresses Markus's comments. >> >> > >> >> > changelog >> >> > --------- >> >> > >> >> > V1 -> V2 >> >> > >> >> > - Make class_info's key 'desc' optional >> >> > - Better indentation >> >> > - Doc fixes >> >> > >> >> > V0 -> V1 >> >> > >> >> > - Coding style fixes >> >> > - Make 'BAR' and 'IRQ' keys lowercase >> >> > - Add 'irq' key to the documentation >> >> > >> >> > =C2=A0Thanks. >> >> >> >> Looks good, although one comment still applies: PATCH 3/5 regresses i= nfo >> >> pci, 4/5 and 5/5 fix it. =C2=A0Do we care? =C2=A0They're separate bec= ause they're >> >> untested. >> > >> > =C2=A0There are two problems here, which apply for those whom emulate >> > the hardware: >> > >> > 1. 'info pci' output will brake with git bisect >> > >> > 2. As the code is untested, it might be broken >> > >> > =C2=A0Only two 2 seems serious. >> > >> > =C2=A0Michael, does the sparc image on qemu.org have the hardware >> > in question (pci bridge)? >> >> Sparc64 has two Simba bridges, but currently they are broken so there >> are no devices behind them. In addition there should be a DEC 21154 >> bridge. > > =C2=A0Can the DEC one have devices attached to it? It should, but sun4u machine does not even create it yet. There are two DEC 21154 models, located in grackle_pci.c and unin_pci.c (PPC). They should be unified and given a file of their own so they could be used also for Sparc64. >> There is no Sparc64 test image yet (very few Sparc32 machines did have >> any PCI and we don't emulate them), but you can test the output >> without any images: > > =C2=A0Oh man, thanks a lot! > > =C2=A0I got an abort() :) >