From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZqv3-0007fh-6f for qemu-devel@nongnu.org; Tue, 26 Jan 2010 14:17:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZquy-0007ee-24 for qemu-devel@nongnu.org; Tue, 26 Jan 2010 14:17:44 -0500 Received: from [199.232.76.173] (port=36098 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZqux-0007eb-Um for qemu-devel@nongnu.org; Tue, 26 Jan 2010 14:17:39 -0500 Received: from mx20.gnu.org ([199.232.41.8]:9948) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZqux-0008MQ-Eg for qemu-devel@nongnu.org; Tue, 26 Jan 2010 14:17:39 -0500 Received: from mail-pw0-f43.google.com ([209.85.160.43]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZquj-0003cj-IA for qemu-devel@nongnu.org; Tue, 26 Jan 2010 14:17:25 -0500 Received: by pwj11 with SMTP id 11so3494251pwj.2 for ; Tue, 26 Jan 2010 11:17:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20100126164751.GA17684@bee.dooz.org> References: <20100120134940.GA547@pig.zood.org> <20100120165103.GA3303@pig.zood.org> <20100121084406.GA3644@bee.dooz.org> <20100126164751.GA17684@bee.dooz.org> From: Blue Swirl Date: Tue, 26 Jan 2010 21:16:51 +0200 Message-ID: Subject: Re: [Qemu-devel] Re: Stop using "which" in ./configure Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TG/Dr2MgTWluaWVy?= Cc: qemu-devel@nongnu.org On Tue, Jan 26, 2010 at 6:47 PM, Lo=C3=AFc Minier wrote: > On Thu, Jan 21, 2010, M=C3=A5ns Rullg=C3=A5rd wrote: >> I think that entire test is wrong, in fact. =C2=A0It is perfectly possib= le >> for someone on Solaris to install a working "install" command in >> /usr/bin. =C2=A0It is better, if possible, to test whatever "install" >> command is in the path, and complain only if it actually fails. > > =C2=A0As I said, I prefer not changing this without access to a Solaris > =C2=A0platform; would you mind committing the patch as is, and requesting > =C2=A0whoever is interested in the Solaris specific code in qemu to fix t= he > =C2=A0remainder? =C2=A0The patch is a net improvement over what's in ./co= nfigure. The patches didn't apply. Also please send only one patch per message, git am can't handle multiple patches.