qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: "Måns Rullgård" <mans@mansr.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCHv2] configure: verify stdio.h
Date: Tue, 26 Jan 2010 21:31:12 +0200	[thread overview]
Message-ID: <f43fc5581001261131o781b0ab7l9ca497902748f81d@mail.gmail.com> (raw)
In-Reply-To: <yw1x8wbkbuqe.fsf@unicorn.mansr.com>

2010/1/26 Måns Rullgård <mans@mansr.com>:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
>> Verify that stdio.h supports %lld %zd.
>> Some migw variants don't unless requested explicitly (see
>> http://www.mail-archive.com/mingw-w64-public@lists.sourceforge.net/msg00417.html)
>> ), detect them early.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> Acked-by: Juan Quintela <quintela@trasno.org>
>>
>> ---
>>
>> changes from v1:
>>       removed leftover chunk
>>
>>  configure |   20 ++++++++++++++++++++
>>  1 files changed, 20 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 5631bbb..6ba06d6 100755
>> --- a/configure
>> +++ b/configure
>> @@ -123,6 +123,26 @@ else
>>      exit 1
>>  fi
>>
>> +# Check that stdio.h compiler is sane: some
>> +# mingw variants do not support %z %l that we rely on
>> +cat > $TMPC <<EOF
>> +#include <stddef.h>
>> +#include <stdio.h>
>> +size_t z = 1;
>> +long long ll = 2;
>> +int main(void) {
>> +  printf("z=%zd;ll=%lld;\n", z, ll);
>> +  return 0;
>> +}
>> +EOF
>> +
>> +if compile_prog && ($TMPE | grep "z=1;ll=2;" > /dev/null); then
>> +  : C compiler works ok
>> +else
>> +    echo "ERROR: \"$cc\" does not have a working stdio.h"
>> +    exit 1
>> +fi
>> +
>>  check_define() {
>>  cat > $TMPC <<EOF
>>  #if !defined($1)
>
> This makes cross-compiling impossible.  Is that really desirable?

I'd rather drop %ll and %z.

  reply	other threads:[~2010-01-26 19:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 16:01 [Qemu-devel] [PATCHv2] configure: verify stdio.h Michael S. Tsirkin
2010-01-26 18:12 ` [Qemu-devel] " Måns Rullgård
2010-01-26 19:31   ` Blue Swirl [this message]
2010-01-26 21:44 ` Stefan Weil
2010-01-27  9:13   ` Michael S. Tsirkin
2010-01-27 19:02     ` Stefan Weil
2010-01-27 19:12       ` Michael S. Tsirkin
2010-01-27 21:48         ` Måns Rullgård
2010-01-28 17:48       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5581001261131o781b0ab7l9ca497902748f81d@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=mans@mansr.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).