From: Blue Swirl <blauwirbel@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] pci: fix info pci with host bridge.
Date: Mon, 8 Feb 2010 19:23:34 +0200 [thread overview]
Message-ID: <f43fc5581002080923x5348eeaep6f349268fb20498c@mail.gmail.com> (raw)
In-Reply-To: <20100208103709.GA15957@redhat.com>
On Mon, Feb 8, 2010 at 12:37 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote:
>> This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5.
>> pci host bridge doesn't have header type of bridge.
>> The check should be by header type, instead of pci class device.
>>
>> Cc: Blue Swirl <blauwirbel@gmail.com>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
>
> So the effect of this will be that info pci won't report
> host bridge, right? IOW, it kind of reverts
> 525e05147d5a3bdc08caa422d108c1ef71b584b5, or am I
> missing something?
Yes, it breaks info pci. PBM/APB does not use PCI_HEADER_TYPE_BRIDGE.
next prev parent reply other threads:[~2010-02-08 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 6:40 [Qemu-devel] [PATCH] pci: fix info pci with host bridge Isaku Yamahata
2010-02-08 10:10 ` [Qemu-devel] " Michael S. Tsirkin
2010-02-08 10:35 ` Michael S. Tsirkin
2010-02-08 10:37 ` Michael S. Tsirkin
2010-02-08 17:23 ` Blue Swirl [this message]
2010-02-09 3:02 ` Isaku Yamahata
2010-02-09 18:51 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5581002080923x5348eeaep6f349268fb20498c@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).