From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NeXL5-0006ZG-9K
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:23:59 -0500
Received: from [199.232.76.173] (port=35405 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NeXL4-0006Yj-Rr
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:23:58 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <blauwirbel@gmail.com>) id 1NeXL4-0006RN-6M
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:23:58 -0500
Received: from mail-pz0-f176.google.com ([209.85.222.176]:39543)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NeXL3-0006Qr-QH
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:23:58 -0500
Received: by pzk6 with SMTP id 6so5365185pzk.18
	for <qemu-devel@nongnu.org>; Mon, 08 Feb 2010 09:23:56 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20100208103709.GA15957@redhat.com>
References: <20100208064038.GC22624@valinux.co.jp>
	<20100208103709.GA15957@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 8 Feb 2010 19:23:34 +0200
Message-ID: <f43fc5581002080923x5348eeaep6f349268fb20498c@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH] pci: fix info pci with host bridge.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org

On Mon, Feb 8, 2010 at 12:37 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote:
>> This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5.
>> pci host bridge doesn't have header type of bridge.
>> The check should be by header type, instead of pci class device.
>>
>> Cc: Blue Swirl <blauwirbel@gmail.com>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
>
> So the effect of this will be that info pci won't report
> host bridge, right? IOW, it kind of reverts
> 525e05147d5a3bdc08caa422d108c1ef71b584b5, or am I
> missing something?

Yes, it breaks info pci. PBM/APB does not use PCI_HEADER_TYPE_BRIDGE.