From: Blue Swirl <blauwirbel@gmail.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] apb_pci: fix header type of pbm pci host bridge.
Date: Mon, 8 Feb 2010 19:29:32 +0200 [thread overview]
Message-ID: <f43fc5581002080929k2476dbf6xdf7d6e8dea80e8d2@mail.gmail.com> (raw)
In-Reply-To: <20100208064503.GE22624@valinux.co.jp>
On Mon, Feb 8, 2010 at 8:45 AM, Isaku Yamahata <yamahata@valinux.co.jp> wrote:
> The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00
> specifies pbm pci host bridge is type of bridge.
> It contradicts with pbm_pci_host_init().
Bridge header type in qdev info is needed so that the write masks are
correct. Otherwise the masks make for example PCI_SECONDARY_BUS
readonly. But the device uses PCI_HEADER_TYPE_NORMAL. So both are
correct.
prev parent reply other threads:[~2010-02-08 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 6:45 [Qemu-devel] [PATCH] apb_pci: fix header type of pbm pci host bridge Isaku Yamahata
2010-02-08 10:26 ` [Qemu-devel] " Michael S. Tsirkin
2010-02-08 10:27 ` Michael S. Tsirkin
2010-02-08 17:29 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5581002080929k2476dbf6xdf7d6e8dea80e8d2@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).