From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NeXQr-0000GQ-Nv
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:29:57 -0500
Received: from [199.232.76.173] (port=57331 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NeXQr-0000G5-6A
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:29:57 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <blauwirbel@gmail.com>) id 1NeXQq-0008KP-IH
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:29:56 -0500
Received: from mail-pz0-f176.google.com ([209.85.222.176]:40570)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NeXQq-0008JW-0g
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:29:56 -0500
Received: by pzk6 with SMTP id 6so5371147pzk.18
	for <qemu-devel@nongnu.org>; Mon, 08 Feb 2010 09:29:53 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20100208064503.GE22624@valinux.co.jp>
References: <20100208064503.GE22624@valinux.co.jp>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 8 Feb 2010 19:29:32 +0200
Message-ID: <f43fc5581002080929k2476dbf6xdf7d6e8dea80e8d2@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH] apb_pci: fix header type of pbm pci host
	bridge.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Mon, Feb 8, 2010 at 8:45 AM, Isaku Yamahata <yamahata@valinux.co.jp> wrote:
> The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00
> specifies pbm pci host bridge is type of bridge.
> It contradicts with pbm_pci_host_init().

Bridge header type in qdev info is needed so that the write masks are
correct. Otherwise the masks make for example PCI_SECONDARY_BUS
readonly. But the device uses PCI_HEADER_TYPE_NORMAL. So both are
correct.