From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ng1As-0002ge-Iv
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 14:27:34 -0500
Received: from [199.232.76.173] (port=44138 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ng1As-0002gE-4M
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 14:27:34 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <blauwirbel@gmail.com>) id 1Ng1Ar-0005kc-H0
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 14:27:34 -0500
Received: from mail-px0-f203.google.com ([209.85.216.203]:54755)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Ng1Ar-0005kU-7G
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 14:27:33 -0500
Received: by pxi41 with SMTP id 41so1862674pxi.27
	for <qemu-devel@nongnu.org>; Fri, 12 Feb 2010 11:27:32 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1265841648-27249-1-git-send-email-atar4qemu@google.com>
References: <1265841648-27249-1-git-send-email-atar4qemu@google.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Fri, 12 Feb 2010 21:27:12 +0200
Message-ID: <f43fc5581002121127g13e540c3w30dd3abf09ed70a@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: sparc32 fix spurious dma interrupts
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Artyom Tarasenko <atar4qemu@googlemail.com>
Cc: qemu-devel@nongnu.org, Artyom Tarasenko <atar4qemu@gmail.com>

On Thu, Feb 11, 2010 at 12:40 AM, Artyom Tarasenko
<atar4qemu@googlemail.com> wrote:
> Don't raise interrupt when not enabled.
> Don't set DMA_INTR bit spuriously.
> Don't print misleading debug messages "Raise IRQ" when not raising any.

This breaks most of my Linux tests. *BSD are unaffected. For example
sparc-test 2.0:

eth0: LANCE 52:54:00:12:34:56
esp0: IRQ 36 SCSI ID 7 Clk 40MHz CCYC=25000 CCF=8 TOut 167 NCR53C9XF(espfast)
ESP: Total of 1 ESP hosts found, 1 actually in use.
scsi0 : Sparc ESP100A-FAST
esp0: Aborting command
esp0: dumping state
esp0: dma -- cond_reg<a4400311> addr<f0010e64>
esp0: SW [sreg<11> sstep<04> ireg<18>]
esp0: HW reread [sreg<93> sstep<00> ireg<10>]
esp0: current command [tgt<02> lun<00> pphase<CLUELESS> cphase<DATAIN>]
esp0: disconnected
esp0: Aborting command
esp0: dumping state
esp0: dma -- cond_reg<a4400310> addr<f0010e64>
esp0: SW [sreg<11> sstep<04> ireg<18>]
esp0: HW reread [sreg<03> sstep<04> ireg<00>]
esp0: current command [tgt<02> lun<00> pphase<UNISSUED> cphase<UNISSUED>]
esp0: disconnected
esp0: Resetting scsi bus
esp0: SCSI bus reset interrupt
esp0: Aborting command
esp0: dumping state
esp0: dma -- cond_reg<a4400211> addr<f000d007>
esp0: SW [sreg<03> sstep<04> ireg<80>]
esp0: HW reread [sreg<91> sstep<04> ireg<18>]
esp0: current command [tgt<02> lun<00> pphase<UNISSUED> cphase<UNISSUED>]
esp0: disconnected
scsi: Device offlined - not ready after error recovery: host 0 channel
0 id 2 lun 0

Since Open/NetBSD still works, there may be yet again another bug that
your patch uncovers.