From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nil8t-0000Le-Hi
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 03:56:51 -0500
Received: from [199.232.76.173] (port=42642 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nil8t-0000LW-85
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 03:56:51 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <blauwirbel@gmail.com>) id 1Nil8s-0001mE-9m
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 03:56:50 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:48973)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Nil8r-0001mA-Vn
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 03:56:50 -0500
Received: by pwi4 with SMTP id 4so836569pwi.4
	for <qemu-devel@nongnu.org>; Sat, 20 Feb 2010 00:56:48 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <ee2e06e91002191024rc2914eeia8a772e2e096f8cb@mail.gmail.com>
References: <ee2e06e91002191024rc2914eeia8a772e2e096f8cb@mail.gmail.com>
Date: Sat, 20 Feb 2010 10:56:48 +0200
Message-ID: <f43fc5581002200056h3b898e13xab4521fa311d2bdb@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] target-sparc: fix --enable-debug build
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jay Foad <jay.foad@gmail.com>
Cc: qemu-devel@nongnu.org

On 2/19/10, Jay Foad <jay.foad@gmail.com> wrote:
> On Linux/x86, configuring with --enable-debug, I get:
>
>   CC    sparc64-linux-user/translate.o
>  /home/foad/git/qemu/target-sparc/translate.c: In function
>  =E2=80=98gen_load_trap_state_at_tl=E2=80=99:
>  /home/foad/git/qemu/target-sparc/translate.c:1684: error: incompatible
>  type for argument 3 of =E2=80=98tcg_gen_add_i32=E2=80=99
>  /home/foad/git/qemu/tcg/tcg-op.h:422: note: expected =E2=80=98TCGv_i32=
=E2=80=99 but
>  argument is of type =E2=80=98TCGv_i64=E2=80=99
>  make[1]: *** [translate.o] Error 1
>
>  Does this look like a reasonable fix?
>
>  Signed-off-by: Jay Foad <address@hidden>

Yes, except for the Signed-off-by: line.