* [Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug
@ 2010-02-19 18:57 Jay Foad
2010-02-20 8:59 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Jay Foad @ 2010-02-19 18:57 UTC (permalink / raw)
To: qemu-devel
After configuring with --enable-debug on Linux/x86, I get:
foad@foad-ubuntu:~/qemu/objdir-git$ qemu-alpha /dev/null
qemu-alpha: /home/foad/git/qemu/tcg/tcg.c:1055:
tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed.
Aborted
(and the same for all other targets). The qemu_ld32s op appears to be
unused on 32-bit hosts. Is it OK to just remove it?
Signed-off-by: Jay Foad <address@hidden>
---
tcg/tcg-opc.h | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h
index 89db3b4..838f1f4 100644
--- a/tcg/tcg-opc.h
+++ b/tcg/tcg-opc.h
@@ -224,11 +224,6 @@ DEF2(qemu_ld32u, 1, 1, 1, TCG_OPF_CALL_CLOBBER |
TCG_OPF_SIDE_EFFECTS)
DEF2(qemu_ld32u, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
#endif
#if TARGET_LONG_BITS == 32
-DEF2(qemu_ld32s, 1, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
-#else
-DEF2(qemu_ld32s, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
-#endif
-#if TARGET_LONG_BITS == 32
DEF2(qemu_ld64, 2, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
#else
DEF2(qemu_ld64, 2, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug
2010-02-19 18:57 [Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug Jay Foad
@ 2010-02-20 8:59 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2010-02-20 8:59 UTC (permalink / raw)
To: Jay Foad; +Cc: qemu-devel
On 2/19/10, Jay Foad <jay.foad@gmail.com> wrote:
> After configuring with --enable-debug on Linux/x86, I get:
>
> foad@foad-ubuntu:~/qemu/objdir-git$ qemu-alpha /dev/null
> qemu-alpha: /home/foad/git/qemu/tcg/tcg.c:1055:
> tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed.
> Aborted
>
> (and the same for all other targets). The qemu_ld32s op appears to be
> unused on 32-bit hosts. Is it OK to just remove it?
Should be OK.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-20 8:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-19 18:57 [Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug Jay Foad
2010-02-20 8:59 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).