From: Blue Swirl <blauwirbel@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] commit d354899 (Fix OpenBSD linker warning, 2010-02-23)
Date: Thu, 25 Feb 2010 19:37:52 +0200 [thread overview]
Message-ID: <f43fc5581002250937x268e98d6iaf90ed4bb2c61ca1@mail.gmail.com> (raw)
In-Reply-To: <hm5vqh$90s$1@dough.gmane.org>
On 2/25/10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > - if (b)
> > - sprintf(b, "...");
> > + if (b) {
> > + memcpy(b, "...", sizeof("..."));
> > + }
> >
>
> What's wrong with strcpy? :-) (I doubt OpenBSD warns about that too).
But of course, with code containing strcpy() you get this:
LINK i386-softmmu/qemu
i386-dis.o(.text+0x3aac): In function `oappend':
/src/qemu/i386-dis.c:4656: warning: strcpy() is almost always misused, p
lease use strlcpy()
/usr/X11R6/lib/libX11.so.11.2: warning: strcat() is almost always misuse
d, please use strlcat()
/usr/X11R6/lib/libX11.so.11.2: warning: sprintf() is often misused, plea
se use snprintf()
With clean code, the only warnings come from X11 libraries:
LINK sparc64-softmmu/qemu-system-sparc64
/usr/X11R6/lib/libX11.so.11.2: warning: strcpy() is almost always misuse
d, please use strlcpy()
/usr/X11R6/lib/libX11.so.11.2: warning: strcat() is almost always misuse
d, please use strlcat()
/usr/X11R6/lib/libX11.so.11.2: warning: sprintf() is often misused, plea
se use snprintf()
next prev parent reply other threads:[~2010-02-25 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 14:00 [Qemu-devel] commit d354899 (Fix OpenBSD linker warning, 2010-02-23) Paolo Bonzini
2010-02-25 17:37 ` Blue Swirl [this message]
2010-02-25 18:14 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5581002250937x268e98d6iaf90ed4bb2c61ca1@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).