From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nq9tT-0002yR-ND
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 13:47:31 -0500
Received: from [199.232.76.173] (port=53216 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nq9tT-0002yF-B5
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 13:47:31 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <blauwirbel@gmail.com>) id 1Nq9tS-0005R8-8T
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 13:47:31 -0500
Received: from mail-px0-f176.google.com ([209.85.216.176]:43094)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Nq9tR-0005Qu-UI
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 13:47:30 -0500
Received: by pxi6 with SMTP id 6so724509pxi.18
	for <qemu-devel@nongnu.org>; Fri, 12 Mar 2010 10:47:28 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B990445.5030303@codemonkey.ws>
References: <4B98FA68.7000901@codemonkey.ws>
	<1268318923-13397-1-git-send-email-avi@redhat.com>
	<4B990445.5030303@codemonkey.ws>
Date: Fri, 12 Mar 2010 20:47:27 +0200
Message-ID: <f43fc5581003121047r4b260d1fh4438f2f15605682c@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH] CODING_STYLE: Reserve qemu_ prefix for
	library wrappers
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On 3/11/10, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 03/11/2010 08:48 AM, Avi Kivity wrote:
>
> > Signed-off-by: Avi Kivity<avi@redhat.com>
> > ---
> >  CODING_STYLE |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/CODING_STYLE b/CODING_STYLE
> > index a579cb1..92036f3 100644
> > --- a/CODING_STYLE
> > +++ b/CODING_STYLE
> > @@ -49,6 +49,9 @@ and is therefore likely to be changed.
> >  Typedefs are used to eliminate the redundant 'struct' keyword.  It is the
> >  QEMU coding style.
> >
> > +When wrapping standard library functions, use the prefix qemu_ to alert
> > +readers that they are seeing a wrapped version; otherwise avoid this
> prefix.
> > +
> >
> >
>
>  Acked-by: Anthony Liguori <aliguori@us.ibm.com>
>
>  But I'd like to also see others agree with this.

OK for me too.