From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ns0RD-00088R-Gv
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 17:05:59 -0400
Received: from [199.232.76.173] (port=37953 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ns0RC-00087j-Up
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 17:05:58 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <blauwirbel@gmail.com>) id 1Ns0RC-0008Ro-4p
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 17:05:58 -0400
Received: from mail-px0-f200.google.com ([209.85.216.200]:34410)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Ns0RB-0008Qy-Pq
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 17:05:57 -0400
Received: by pxi38 with SMTP id 38so727407pxi.27
	for <qemu-devel@nongnu.org>; Wed, 17 Mar 2010 14:05:51 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4BA142C4.5030805@codemonkey.ws>
References: <1268053115.2130.4.camel@localhost.localdomain>
	<201003171708.04633.paul@codesourcery.com>
	<4BA10E49.90703@codemonkey.ws>
	<201003171743.06728.paul@codesourcery.com>
	<f43fc5581003171315g7e14afdat2c31d54bb1d42bd0@mail.gmail.com>
	<4BA13E6E.4060708@codemonkey.ws>
	<1268859417.23390.3.camel@localhost.localdomain>
	<4BA142C4.5030805@codemonkey.ws>
Date: Wed, 17 Mar 2010 23:05:51 +0200
Message-ID: <f43fc5581003171405m20560a6eu5c3895c58ed3c37d@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable
	default in switch statement
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Bolle <pebolle@tiscali.nl>, Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

On 3/17/10, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 03/17/2010 03:56 PM, Paul Bolle wrote:
>
> > On Wed, 2010-03-17 at 15:41 -0500, Anthony Liguori wrote:
> >
> >
> > > On 03/17/2010 03:15 PM, Blue Swirl wrote:
> > >
> > >
> > > > This breaks build (gcc 4.3.2):
> > > >    CC    usb-linux.o
> > > > cc1: warnings being treated as errors
> > > > /src/qemu/usb-linux.c: In function 'usb_linux_update_endp_table':
> > > > /src/qemu/usb-linux.c:759: error: 'type' may be used uninitialized in
> > > > this function
> > > >
> > > >
> > > >
> > > That's unfortunate.  I'll revert.
> > >
> > >
> > I can't reproduce this with gcc-4.4.3-8.fc13.i686 (which I'm currently
> > running). The patch was tested and submitted when I was running
> > gcc-4.4.3-6.fc13.i686.
> >
> >
>
>  Yeah, it worked for me, but clearly older versions of gcc are less smart
> about calculating ranges.

Actually OpenBSD gcc (3.4.4) has no problems.