From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NsMOW-00049h-0x
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 16:32:40 -0400
Received: from [199.232.76.173] (port=60098 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NsMOV-000499-H0
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 16:32:39 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <blauwirbel@gmail.com>) id 1NsMOU-00011S-Tl
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 16:32:39 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:42310)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1NsMOU-00011E-JU
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 16:32:38 -0400
Received: by pwi9 with SMTP id 9so1840650pwi.4
	for <qemu-devel@nongnu.org>; Thu, 18 Mar 2010 13:32:36 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <70f06bad1003170559u1d5ab0b0jad069cf0c336aa5a@mail.gmail.com>
References: <70f06bad1003170559u1d5ab0b0jad069cf0c336aa5a@mail.gmail.com>
Date: Thu, 18 Mar 2010 22:32:36 +0200
Message-ID: <f43fc5581003181332n2a3dea2bs85a8e91be4b8beb8@mail.gmail.com>
Subject: Re: [Qemu-devel] NetBSD qemu block device support
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: haad <haad@netbsd.org>
Cc: qemu-devel@nongnu.org

On 3/17/10, haad <haad@netbsd.org> wrote:
> Hi folks,
>
>  This patch at [1] add support for NetBSD block ioctl calls to qemu
>  block-raw.c file. It was written for xen version of qemu but basically
>  it will work with vanilla qemu, too. Would anyone like to commit this
>  patch so it can be included into the base xen distribution ?

The patch does not apply to current development repository.

There is no description of the change suitable for changelog without
any editing.

Signed-off-by: line is missing.

The patch combines formatting (whitespace) changes with functional
changes. The formatting changes seem useless.

The essence of the patch is twofold, It adds NetBSD specific includes
and NetBSD specific code to raw_getlength(). These look OK, except
formatting may be a bit off (no space after if) and currently the code
probably should be surrounded by
#ifdef DIOCGWEDGEINFO
#endif
or just #ifdef __NetBSD__.