From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NtQy6-0006MQ-Jx for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:37:50 -0400 Received: from [199.232.76.173] (port=39698 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NtQy6-0006MC-97 for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:37:50 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NtQy5-0007pH-6g for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:37:49 -0400 Received: from mail-px0-f173.google.com ([209.85.216.173]:39186) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NtQy4-0007ov-Qy for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:37:49 -0400 Received: by pxi3 with SMTP id 3so1304271pxi.28 for ; Sun, 21 Mar 2010 12:37:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4BA670B5.6010704@codemonkey.ws> References: <1269071241.1725.8.camel@localhost.localdomain> <4BA670B5.6010704@codemonkey.ws> Date: Sun, 21 Mar 2010 21:37:45 +0200 Message-ID: Subject: Re: [Qemu-devel] build error in current master From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paul Bolle , Anthony Liguori , qemu-devel@nongnu.org On 3/21/10, Anthony Liguori wrote: > On 03/20/2010 03:14 AM, Blue Swirl wrote: > > > On 3/20/10, Paul Bolle wrote: > > > > > > > 0) Building current master > (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, > > > Introduce a default qmp session) fails here: > > > > > > $ make> /dev/null > > > cc1: warnings being treated as errors > > > curses.c: In function =E2=80=98curses_display_init=E2=80=99: > > > curses.c:341: error: initialization from incompatible pointer type > > > make: *** [curses.o] Error 1 > > > > > > 1) It seems caused by commit d7234f4d (committed half a day ago): > > > > > > $ git blame curses.c | grep 341 > > > d7234f4d (Anthony Liguori 2010-03-17 17:59:26 -0500 341) static > > > Notifier notifier =3D { .notify =3D curses_atexit }; > > > > > > $ git log -1 d7234f4d --pretty=3Dshort > > > commit d7234f4d7e373a708e1df9ab565a71b71b189025 > > > Author: Anthony Liguori > > > > > > Convert atexit users to exit_notifier > > > > > > Regards, > > > > > > > > Fixed in HEAD. > > > > > > I've reverted a bunch of these commits. They're still a work-in-progres= s. > Looks like I pushed the wrong branch. Maybe you shouldn't have reverted: CC curses.o cc1: warnings being treated as errors /src/qemu/curses.c: In function 'curses_display_init': /src/qemu/curses.c:345: error: passing argument 1 of 'atexit' from incompatible pointer type