From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NuW5Y-0002jD-RC
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:18:00 -0400
Received: from [140.186.70.92] (port=55884 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NuW5X-0002i8-IT
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:18:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1NuW5W-0005zk-0I
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:17:59 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:33602)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1NuW5V-0005zc-NP
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:17:57 -0400
Received: by pwi9 with SMTP id 9so5161872pwi.4
	for <qemu-devel@nongnu.org>; Wed, 24 Mar 2010 12:17:56 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4BAA58C3.7040006@suse.de>
References: <1269451840-13941-1-git-send-email-agraf@suse.de>
	<1269451840-13941-4-git-send-email-agraf@suse.de>
	<f43fc5581003241122o7561bbbfp8b14904c40ac615f@mail.gmail.com>
	<4BAA58C3.7040006@suse.de>
Date: Wed, 24 Mar 2010 21:17:56 +0200
Message-ID: <f43fc5581003241217o43f65af0s6f68acea8b756e2f@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Don't compile in virtio-pci
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel@nongnu.org

On 3/24/10, Alexander Graf <agraf@suse.de> wrote:
> Blue Swirl wrote:
>  > On 3/24/10, Alexander Graf <agraf@suse.de> wrote:
>  >
>  >> As soon as virtio-pci.c gets compiled and used on S390 the internal qdev magic
>  >>  gets confused and tries to give us PCI devices instead of S390 virtio devices.
>  >>
>  >>  Since we don't have PCI on S390, we can safely not compile virtio-pci at all.
>  >>
>  >>  In order to do this I added a new config option "CONFIG_PCI" that I enabled
>  >>  for every platform except S390. Thanks to this the change should be a complete
>  >>  nop for every other platform.
>  >>
>  >
>  > The name should be CONFIG_VIRTIO_PCI, CONFIG_PCI would enable
>  > compilation of pci.c.
>  >
>
>
> My idea was to keep the config option generic and rip out all PCI stuff
>  from s390x-softmmu. We don't even do MMIO :-).

In that case you should also rip out all PCI cards.